refactor(onboarding): migrate to module-based structure and extract service layer#9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restructures the backend from a layer-based architecture to a module-based architecture and extracts onboarding business logic into a dedicated service layer.
The onboarding flow is now clearly separated into:
PATCH /onboarding)POST /onboarding/complete)Controllers are thin, business logic lives in services, and shared utilities are centralized.
Scope
controllers,routes,lib) to module-based architecture.OnboardingService./shared.Architectural Changes
1. Module-Based Structure
Reorganized features into self-contained modules:
modules/authmodules/healthmodules/onboardingEach module now contains:
Shared utilities moved to:
shared/authshared/constantsshared/errorsshared/middlewaresEnvironment config moved to:
config/env.schema.tsOnboarding Refactor
Controller → Service Extraction
onboarding.controller.tsOnboardingService(360 LOC)Endpoint Changes
PUT /onboarding→ replaced with:PATCH /onboarding(save draft only)POST /onboarding/complete(finalize onboarding)Completion logic separated from draft updates.
Validation Changes
onboarding-status.schema.tsonboarding-status-update.schema.tsPATCHcannot mark onboarding as completed/onboarding/completeImproved DB draft typing: