Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mail_livekit/static/src/discuss/livekit_service.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@ class LivekitService {
publication,
participant
);
} else if (!publication.isSubscribed) {
log(`Requesting missing audio subscription for ${identity}`);
publication.setSubscribed?.(true);
}
}

Expand Down
39 changes: 39 additions & 0 deletions mail_livekit/static/tests/livekit_adapter.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,24 @@ function makeRemoteAudioTrack(identity) {
return {audioElement, participant, publication, track};
}

function makeRemoteAudioPublication(identity, {isSubscribed = false} = {}) {
const publication = {
source: Source.MICROPHONE,
track: null,
isSubscribed,
setSubscribed: (subscribed) => {
publication.requestedSubscription = subscribed;
},
};
const participant = {
identity,
sid: `${identity}-sid`,
audioTrackPublications: new Map([["microphone", publication]]),
videoTrackPublications: new Map(),
};
return {participant, publication};
}

describe("mail_livekit livekit adapter", () => {
after(() => {
window.LivekitClient = originalLivekitClient;
Expand Down Expand Up @@ -107,4 +125,25 @@ describe("mail_livekit livekit adapter", () => {
track,
});
});

test("rebindExistingTracks requests missing remote microphone subscriptions in a multi-person call", async () => {
const {participant: alreadySubscribed} = makeRemoteAudioTrack("partner:10");
const {participant: missingPeerA, publication: missingPublicationA} =
makeRemoteAudioPublication("partner:11");
const {participant: missingPeerB, publication: missingPublicationB} =
makeRemoteAudioPublication("partner:12");

livekitService.room = {
remoteParticipants: new Map([
[alreadySubscribed.identity, alreadySubscribed],
[missingPeerA.identity, missingPeerA],
[missingPeerB.identity, missingPeerB],
]),
};

await livekitService.rebindExistingTracks();

expect(missingPublicationA.requestedSubscription).toBe(true);
expect(missingPublicationB.requestedSubscription).toBe(true);
});
});
Loading