feat: better json fontification with json-ts-mode, fix: handles stderr in nix-drv-mode#208
Open
ed9w2in6 wants to merge 2 commits intoNixOS:masterfrom
Open
feat: better json fontification with json-ts-mode, fix: handles stderr in nix-drv-mode#208ed9w2in6 wants to merge 2 commits intoNixOS:masterfrom
ed9w2in6 wants to merge 2 commits intoNixOS:masterfrom
Conversation
replace js-mode with json-ts-mode (part of Emacs core)
nix-drv-mode behaves weirdly when there is stderr which is common when nix warns about feature deprecation replace shell-command-to-string with make-process which allows ignoring stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 commits:
js-modewithjson-ts-modenix-drv-modebehaves weirdly when things got printed to stderr, whichis common when nix warns about feature deprecation
replacing
shell-command-to-stringwithmake-processallows us to ignoring stderr