zigmod: init at 90#217229
Conversation
|
Result of 1 package built:
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1850 |
|
Please do not paste immediately on discourse. |
c661b2c to
cc83dab
Compare
|
I've added a script that generates the list of dependencies. |
2ca9663 to
d396745
Compare
|
I've rewritten the package to take advantage of fixed-output derivations. I've also added a function to build Zigmod packages and a test for it. |
AndersonTorres
left a comment
There was a problem hiding this comment.
LGTM.
Very complex, but LGTM.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2322 |
|
I've added a requirement to specify |
There was a problem hiding this comment.
that url scheme looks rather od. Is file:/// always there? Then we should move the logic into buildZigmodPackage
There was a problem hiding this comment.
No, it can be any scheme. I just use this one for the test. We separate updates of the package and the dependencies now, so the sources of lock and manifest files might be different. I imagine most of the time links to these files should be links to their blobs (contents of the file) from a specific commit.
but name still contains version, so the FOD hash would still be wrong, we just wouldn't notice it, right? |
Oh, right. I will just remove the version then. |
Description of changes
A package manager for the Zig programming language (https://github.com/nektro/zigmod).
Note: it's gonna be broken on Darwin until Zig 0.10.1 is fixed.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)