Skip to content

ankisyncd: fix for anki 23.10#269398

Closed
martinetd wants to merge 2 commits into
NixOS:masterfrom
martinetd:ankisyncd
Closed

ankisyncd: fix for anki 23.10#269398
martinetd wants to merge 2 commits into
NixOS:masterfrom
martinetd:ankisyncd

Conversation

@martinetd
Copy link
Copy Markdown
Member

Description of changes

anki 23.10 broke protocol so this needs an update.

Since upstream is dead we'll replace ankisyncd with anki's built-in server in #261166, but until then let's just update ankisyncd. This updates the anki server to 23.10.1.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

anki 23.10 introduces protocol changes and requires updating the sync server

This patch is more complex than necessary for a few reasons:
- upstream anki-sync-server-rs is dormant; it will take a bit of time to
take over
- anki itself broke 'cargo vendor', and this requires patching three
separate repos in order one after the other; the current patch is a
kludge to just avoid name collision but integrating the required feature
upstream would be preferred.
There are no rust level tests, so disable automatic tests:
ankisyncd> test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
@martinetd martinetd mentioned this pull request Nov 23, 2023
12 tasks
@ofborg ofborg Bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 23, 2023
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@martinetd
Copy link
Copy Markdown
Member Author

Closing this will open a new PR to drop the package instead.

@martinetd martinetd closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants