Skip to content

draco: move to by-name, minimize#440070

Merged
wolfgangwalther merged 3 commits into
NixOS:masterfrom
yzx9:draco-minimize
May 15, 2026
Merged

draco: move to by-name, minimize#440070
wolfgangwalther merged 3 commits into
NixOS:masterfrom
yzx9:draco-minimize

Conversation

@yzx9

@yzx9 yzx9 commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Sep 4, 2025
wolfgangwalther
wolfgangwalther reviewed Sep 12, 2025
View reviewed changes

@wolfgangwalther wolfgangwalther left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why draft? Looks alright, so far.

Comment thread pkgs/by-name/dr/draco/package.nix Outdated
@yzx9

yzx9 commented Sep 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Wow, thanks for the attention! This is still a draft because the new version tinygltf v2.9.6 is not compatible with darco, and even v2.8.23 (the last 2.8 release) isn’t compatible either. I’m not sure whether I should include both versions or just embed it back.

@yzx9
yzx9 force-pushed the draco-minimize branch 3 times, most recently from 54e63d3 to 04313bd Compare September 24, 2025 13:09
@yzx9
yzx9 marked this pull request as ready for review September 24, 2025 13:16
@nix-owners
nix-owners Bot requested a review from jansol September 24, 2025 13:18
@yzx9

yzx9 commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I have inline tinygltf v2.8.7 back since upgrading it to 2.8.8 break draco. And #445078 will add tinygltf

jansol
jansol reviewed Sep 24, 2025
View reviewed changes

@jansol jansol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at surface level (but I haven't tested).

However, considering that I no longer have any use for draco nor tinygltf, I'm thinking of orphaning them. Would meshlab maintainers be interested in taking over, since meshlab appears to be what motivated these changes in the first place?

@yzx9

yzx9 commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

I am happy to add myself as a maintainer

wolfgangwalther
wolfgangwalther reviewed Sep 24, 2025
View reviewed changes
Comment thread pkgs/top-level/all-packages.nix Outdated
wolfgangwalther
wolfgangwalther reviewed Sep 25, 2025
View reviewed changes

@wolfgangwalther wolfgangwalther left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the piecemeal feedback, only noticed this now :/

Comment thread pkgs/by-name/dr/draco/package.nix
Comment thread pkgs/by-name/dr/draco/tinygltf.nix Outdated
@yzx9

yzx9 commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 440070
Commit: 3d3f642ea2ce2c53ab84897ca0a3ee6d1fe890fb

x86_64-linux

✅ 16 packages built:
  • blender
  • blender-hip
  • blendfarm
  • draco
  • exhibit
  • f3d
  • f3d.man
  • openusd
  • python312Packages.f3d
  • python312Packages.f3d.man
  • python312Packages.openusd
  • python313Packages.f3d
  • python313Packages.f3d.man
  • python313Packages.openusd
  • qgis
  • qgis-ltr

aarch64-darwin

✅ 7 packages built:
  • draco
  • f3d
  • openusd
  • python312Packages.f3d
  • python312Packages.openusd
  • python313Packages.f3d
  • python313Packages.openusd

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 13, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 8, 2026
@wolfgangwalther

wolfgangwalther commented May 15, 2026

Copy link
Copy Markdown
Contributor

Sorry, this fell through the cracks again. Just rebased, will run another nixpkgs-review and if all is good merge.

@nixpkgs-ci nixpkgs-ci Bot removed 2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels May 15, 2026
@wolfgangwalther

wolfgangwalther commented May 15, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 440070 --package draco
Commit: 4f5c50df55816520f124ef1a388778729c0a82bc

x86_64-linux

✅ 1 package built:
  • draco

aarch64-linux

✅ 1 package built:
  • draco

x86_64-darwin

✅ 1 package built:
  • draco

aarch64-darwin

✅ 1 package built:
  • draco

@wolfgangwalther
wolfgangwalther added this pull request to the merge queue May 15, 2026
Merged via the queue into NixOS:master with commit 9a2a13a May 15, 2026
26 checks passed
@yzx9

yzx9 commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

@wolfgangwalther thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther
1 more reviewer
@jansol jansol jansol left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yzx9 @wolfgangwalther @jansol