Skip to content

candle: 1.1 -> 1.1.8#440646

Merged
FliegendeWurst merged 2 commits into
NixOS:masterfrom
MarcFontaine:candle
Sep 16, 2025
Merged

candle: 1.1 -> 1.1.8#440646
FliegendeWurst merged 2 commits into
NixOS:masterfrom
MarcFontaine:candle

Conversation

@MarcFontaine
Copy link
Copy Markdown
Contributor

@MarcFontaine MarcFontaine commented Sep 6, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 6, 2025
@MarcFontaine MarcFontaine force-pushed the candle branch 2 times, most recently from 354347c to 2ef7888 Compare September 9, 2025 09:42
@MarcFontaine MarcFontaine marked this pull request as ready for review September 9, 2025 09:53
@nixpkgs-ci nixpkgs-ci Bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 9, 2025
@MarcFontaine MarcFontaine self-assigned this Sep 9, 2025
JohnRTitor
JohnRTitor reviewed Sep 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@JohnRTitor JohnRTitor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate byname migration to a different commit.

@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 11, 2025
FliegendeWurst
FliegendeWurst reviewed Sep 16, 2025
View reviewed changes
Comment thread pkgs/by-name/ca/candle/package.nix Outdated
@MarcFontaine
candle: 1.1 -> 1.1.8
d961b6e 
* Update candle to 1.1.8.
* Add a patch that applies Denvi/Candle#658.
  PR 658 enables the user to save application setting.
@MarcFontaine
candle: migrate to by-name
05cf996
FliegendeWurst
FliegendeWurst approved these changes Sep 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App launches successfully, and the patch also seems to work

@FliegendeWurst FliegendeWurst added this pull request to the merge queue Sep 16, 2025
Merged via the queue into NixOS:master with commit 3d3bebf Sep 16, 2025
28 of 31 checks passed
@MarcFontaine
Copy link
Copy Markdown
Contributor Author

MarcFontaine commented Sep 18, 2025

@JohnRTitor @FliegendeWurst Thanks again for the review

@MarcFontaine MarcFontaine deleted the candle branch September 18, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor

@astro astro Awaiting requested review from astro

Assignees

@MarcFontaine MarcFontaine

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcFontaine @FliegendeWurst @JohnRTitor