lowdown: fix cygwin build#468178
Merged
Merged
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 101-500
Ericson2314
reviewed
Dec 5, 2025
Comment on lines
+35
to
+36
| # https://github.com/kristapsdz/lowdown/pull/171 | ||
| patches = lib.optional stdenv.hostPlatform.isCygwin ./fix-cygwin-build.patch; |
Member
There was a problem hiding this comment.
Suggested change
| # https://github.com/kristapsdz/lowdown/pull/171 | |
| patches = lib.optional stdenv.hostPlatform.isCygwin ./fix-cygwin-build.patch; | |
| patches = [ | |
| # https://github.com/kristapsdz/lowdown/pull/171 | |
| ./fix-cygwin-build.patch | |
| ]; |
Member
There was a problem hiding this comment.
patches are supposed to be unconditional, and we're going to staging anyways.
Contributor
Author
There was a problem hiding this comment.
I haven't really been doing that because I was worried about the maintenance burden for an obscure platform. I can change them all over though.
Member
There was a problem hiding this comment.
CC @alyssais but I think we do want unconditional patches no matter how obscure the platform is, but I am not sure.
Contributor
Author
There was a problem hiding this comment.
I wouldn't object to this one being unconditional. I have already tested it on other platforms and started a conversation upstream.
corngood
force-pushed
the
cygwin-lowdown
branch
from
838d857 to
f6214bf
Compare
Ericson2314
approved these changes
Dec 5, 2025
nixpkgs-ci
Bot
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream (WIP) PR: kristapsdz/lowdown#171
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.