Skip to content

opencbm: fix build#489055

Merged
vcunat merged 1 commit intoNixOS:masterfrom
Bot-wxt1221:opencbm
Mar 6, 2026
Merged

opencbm: fix build#489055
vcunat merged 1 commit intoNixOS:masterfrom
Bot-wxt1221:opencbm

Conversation

@Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Feb 10, 2026 •
edited
Loading

Fix #487326

Track: #475479

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 10, 2026
@Sigmanificient
Copy link
Member

Sigmanificient commented Feb 10, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 489055
Commit: 43a928c56a54bc0ed8641d2f83089284ab1f2274

x86_64-linux

✅ 2 packages built:
  • nibtools
  • opencbm

@Sigmanificient
Copy link
Member

Sigmanificient commented Feb 10, 2026

@Bot-wxt1221 It seems that your commit is unverified, could you please take a look?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 10, 2026
bjornfor
bjornfor approved these changes Feb 11, 2026
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems upstream is dead[1], so I guess there's no point in trying to fix this upstream now.

[1] Repo is archived: https://github.com/Broadcom-Network-Switching-Software/OpenBCM

@bjornfor
Copy link
Contributor

bjornfor commented Feb 11, 2026

It seems upstream is dead[1], so I guess there's no point in trying to fix this upstream now.

[1] Repo is archived: https://github.com/Broadcom-Network-Switching-Software/OpenBCM

Hehe, wrong repo! https://github.com/OpenCBM/OpenCBM is alive -- have you tried submitting patch upstream?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 11, 2026
@vcunat vcunat added this pull request to the merge queue Mar 6, 2026
@vcunat
Copy link
Member

vcunat commented Mar 6, 2026

Cooperating with upstream would be nice, but I don't think we need to block on that in this simple case.

Merged via the queue into NixOS:master with commit 6748e1e Mar 6, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornfor bjornfor bjornfor approved these changes

@Sigmanificient Sigmanificient Sigmanificient approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opencbm: "cannot use keyword 'false' as enumeration constant" error in build process

4 participants

@Bot-wxt1221 @Sigmanificient @bjornfor @vcunat