Skip to content

nixos/kmscon: revert hwRender option#502952

Merged
r-vdp merged 1 commit into
NixOS:masterfrom
bokicoder:patch-1
Mar 24, 2026
Merged

nixos/kmscon: revert hwRender option#502952
r-vdp merged 1 commit into
NixOS:masterfrom
bokicoder:patch-1

Conversation

@bokicoder
Copy link
Copy Markdown
Contributor

@bokicoder bokicoder commented Mar 24, 2026 •
edited
Loading

kmscon uses the DRM backend by default, but #489469 has disabled it by default, which causes kmscon not to render the interface automatically (black screen).

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@bokicoder bokicoder changed the base branch from nixos-unstable to master March 24, 2026 07:30
@nixpkgs-ci nixpkgs-ci Bot closed this Mar 24, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this Mar 24, 2026
@github-actions github-actions Bot dismissed their stale review March 24, 2026 07:30

Review dismissed automatically

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 24, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 24, 2026
@ccicnce113424
Copy link
Copy Markdown
Member

ccicnce113424 commented Mar 24, 2026

What I must say is that my PR was intended to address the issue where kmscon was occupying the DRM and preventing the GUI from launching, but this issue has now been resolved by kmscon-launch-gui.

@r-vdp r-vdp added this pull request to the merge queue Mar 24, 2026
Merged via the queue into NixOS:master with commit a315c10 Mar 24, 2026
42 of 44 checks passed
@bokicoder bokicoder deleted the patch-1 branch March 24, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@hustlerone hustlerone Awaiting requested review from hustlerone

+1 more reviewer

@ccicnce113424 ccicnce113424 ccicnce113424 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bokicoder @ccicnce113424 @r-vdp