Skip to content

nixos/getty: revert overzealous assertion#502957

Merged
r-vdp merged 1 commit into
NixOS:masterfrom
alyssais:getty-assertion
Mar 24, 2026
Merged

nixos/getty: revert overzealous assertion#502957
r-vdp merged 1 commit into
NixOS:masterfrom
alyssais:getty-assertion

Conversation

@alyssais
Copy link
Copy Markdown
Member

@alyssais alyssais commented Mar 24, 2026

It is not true that autoLoginUser has no effect when loginOptions is set. Partial revert of #489469.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@alyssais
nixos/getty: revert overzealous assertion
a5635ff 
It is not true that autoLoginUser has no effect when loginOptions is
set.  Partial revert of be703cf ("nixos/kmscon: run agetty under
kmscon").
@nixpkgs-ci nixpkgs-ci Bot requested a review from RossComputerGuy March 24, 2026 08:00
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 24, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 24, 2026
@r-vdp r-vdp added this pull request to the merge queue Mar 24, 2026
Merged via the queue into NixOS:master with commit 44cf8e6 Mar 24, 2026
31 checks passed
@alyssais alyssais deleted the getty-assertion branch March 27, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r-vdp r-vdp Awaiting requested review from r-vdp

@hustlerone hustlerone Awaiting requested review from hustlerone

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

1 more reviewer

@ccicnce113424 ccicnce113424 ccicnce113424 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alyssais @ccicnce113424 @r-vdp