Skip to content

bibtool: fix build with GCC >= 14#503132

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
mariovagomarzal:bibtool-fix-gcc14
Mar 24, 2026
Merged

bibtool: fix build with GCC >= 14#503132
Sigmanificient merged 1 commit intoNixOS:masterfrom
mariovagomarzal:bibtool-fix-gcc14

Conversation

@mariovagomarzal
Copy link
Copy Markdown
Contributor

@mariovagomarzal mariovagomarzal commented Mar 24, 2026

Description

bibtool uses K&R-style (old-style) C function definitions, which GCC 14 no longer accepts by default (see -Werror=old-style-definition). This causes the build to fail on Linux with the current toolchain.

The fix compiles bibtool with -std=gnu89 to restore compatibility until upstream merges the proper fix: ge-ne/bibtool#96

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@mariovagomarzal
bibtool: fix build with GCC >= 14
5714366 
bibtool uses K&R-style function definitions, which GCC 14 no longer
accepts by default. Compile with -std=gnu89 as a workaround until
upstream merges ge-ne/bibtool#96.
@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Mar 24, 2026
@nixpkgs-ci nixpkgs-ci bot requested a review from rycee March 24, 2026 21:16
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Mar 24, 2026
@Sigmanificient Sigmanificient added this pull request to the merge queue Mar 24, 2026
@Sigmanificient
Copy link
Copy Markdown
Member

Sigmanificient commented Mar 24, 2026

Merged via the queue into NixOS:master with commit 4a7a4e2 Mar 24, 2026
29 checks passed
@yzhou216
Copy link
Copy Markdown
Contributor

yzhou216 commented Mar 24, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 503132
Commit: 57143660a0b8014df6ba679762e3d8c54165bda7 (subsequent changes)
Merge: 9f226ca64ac110eb95bac0c060943952a1955d24

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/23515357134

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-503132-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/qmrhwi2a3vw2s9j51xbzch1qd2r5qnw2-bibtool-2.68 \
  /nix/store/qw3n1795mhjsdb4qzniw4miqbkwgxgxk-termpdf.py-2022-03-28 \
  /nix/store/s03pq8h691xa5vl5h25g98rw83qlxd6v-termpdf.py-2022-03-28-dist
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-503132-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/jv4f6qjgj30vwvs9dxa8q05rhqd0x5dk-bibtool-2.68 \
  /nix/store/d7n92ngc9qy3npkn962wjimh0ir9di29-termpdf.py-2022-03-28 \
  /nix/store/bm24rshkc4p78zdh88by0mdz1s30l343-termpdf.py-2022-03-28-dist
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-503132-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/094fv0i303mkrbdn09bb3596kds1cql2-bibtool-2.68 \
  /nix/store/3drdh0z4cdd14k8870r0czc7jz2kjziy-termpdf.py-2022-03-28 \
  /nix/store/w9ihgzrx98ghgdxl6512gr6kr01aha1g-termpdf.py-2022-03-28-dist
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-503132-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/sz4hs44xnnpml6lbb0jnfwhr6n12mp2f-bibtool-2.68 \
  /nix/store/p0szik1zpa8kkli5dy63vc23rq6rdm1c-termpdf.py-2022-03-28 \
  /nix/store/ha66a1z67dzbyjl9lsqp3zw0aisz4ps4-termpdf.py-2022-03-28-dist

x86_64-linux

✅ 3 packages built:
  • bibtool
  • termpdfpy
  • termpdfpy.dist

aarch64-linux

✅ 3 packages built:
  • bibtool
  • termpdfpy
  • termpdfpy.dist

x86_64-darwin (sandbox = true)

✅ 3 packages built:
  • bibtool
  • termpdfpy
  • termpdfpy.dist

aarch64-darwin (sandbox = true)

✅ 3 packages built:
  • bibtool
  • termpdfpy
  • termpdfpy.dist

yzhou216
yzhou216 approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@yzhou216 yzhou216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

@rycee rycee Awaiting requested review from rycee

+1 more reviewer

@yzhou216 yzhou216 yzhou216 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mariovagomarzal @Sigmanificient @yzhou216