Skip to content

rlottie: fix build on darwin - #520951

Merged
mdaniels5757 merged 1 commit into
NixOS:masterfrom
sveitser:ma/darwin-fix-rlottie
May 25, 2026
Merged

rlottie: fix build on darwin#520951
mdaniels5757 merged 1 commit into
NixOS:masterfrom
sveitser:ma/darwin-fix-rlottie

Conversation

@sveitser

@sveitser sveitser commented May 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Conflict due to use of format as file name.

Upstream fix: Samsung/rlottie#590

ZHF: #516381

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci
nixpkgs-ci Bot requested a review from CRTified May 16, 2026 14:40
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels May 16, 2026
@sveitser

sveitser commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 520951
Commit: 59c73cc5d9ac954d2063d0bff2d8cc40bf167030

aarch64-darwin

✅ 4 packages built:
  • libsForQt5.rlottie-qml
  • libsForQt5.rlottie-qml.dev
  • lottieconverter
  • rlottie

@mdaniels5757 mdaniels5757 added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 16, 2026
@ofborg ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label May 16, 2026
ethancedwards8
ethancedwards8 previously requested changes May 18, 2026
View reviewed changes

@ethancedwards8 ethancedwards8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tho

Comment thread pkgs/by-name/rl/rlottie/package.nix
@mdaniels5757 mdaniels5757 added the backport release-26.05 Backport PR automatically label May 25, 2026
@mdaniels5757
mdaniels5757 force-pushed the ma/darwin-fix-rlottie branch from 59c73cc to 890d046 Compare May 25, 2026 20:10
@mdaniels5757

mdaniels5757 commented May 25, 2026

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 520951
Commit: 890d046e97c62390779d5ec2bc115d33642657ed

x86_64-linux

✅ 4 packages built:
  • libsForQt5.rlottie-qml
  • lomiri.teleports
  • lottieconverter
  • rlottie

aarch64-linux

✅ 4 packages built:
  • libsForQt5.rlottie-qml
  • lomiri.teleports
  • lottieconverter
  • rlottie

x86_64-darwin

✅ 3 packages built:
  • libsForQt5.rlottie-qml
  • lottieconverter
  • rlottie

aarch64-darwin

✅ 3 packages built:
  • libsForQt5.rlottie-qml
  • lottieconverter
  • rlottie

@mdaniels5757
mdaniels5757 added this pull request to the merge queue May 25, 2026
Merged via the queue into NixOS:master with commit 09524d4 May 25, 2026
27 checks passed
@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request May 25, 2026
Merged
@nixpkgs-ci

nixpkgs-ci Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-26.05:

@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CRTified CRTified Awaiting requested review from CRTified
1 more reviewer
@ethancedwards8 ethancedwards8 ethancedwards8 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. backport release-26.05 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sveitser @mdaniels5757 @ethancedwards8