Skip to content

[haskell-updates] stack: patch for semaphore-compat >= 2.0 - #534567

Merged
wolfgangwalther merged 3 commits into
NixOS:haskell-updatesfrom
sternenseemann:stack-cleanups
Jul 2, 2026
Merged

[haskell-updates] stack: patch for semaphore-compat >= 2.0#534567
wolfgangwalther merged 3 commits into
NixOS:haskell-updatesfrom
sternenseemann:stack-cleanups

Conversation

@sternenseemann

@sternenseemann sternenseemann commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

If we want to build stack wtih GHC 9.12.5, we'll have to work around commercialhaskell/stack#6934 somehow.

Things done

@sternenseemann
sternenseemann changed the base branch from master to haskell-updates June 23, 2026 12:22
@nixpkgs-ci nixpkgs-ci Bot closed this Jun 23, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this Jun 23, 2026
@nixpkgs-ci
nixpkgs-ci Bot requested review from maralorn and wolfgangwalther June 23, 2026 12:32
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Jun 23, 2026
@mpilgrem

mpilgrem commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Stack is not intended to be built against packages other than those specified by its stack.yaml file. See: https://hackage.haskell.org/package/stack.

'Official' Stack 3.11.1 binaries are built against GHC 9.10.3 and (mostly) packages in Stackage LTS Haskell 24.43. (Unusually, because Stackage is not up to date with developments with crypton-*, there are a number of extra-deps at the moment.)

EDIT: My general approach is for the most recent 'official' Stack binaries to be built against the most recent Stackage LTS Haskell snapshot. As soon as Stackage adopts a version of GHC that depends on semaphore-compat >= 2.0.0, Stack will aim to support it. (However, I will need to understand what that will mean for users of earlier versions of GHC that support semaphore.)

@mpilgrem

mpilgrem commented Jun 26, 2026

Copy link
Copy Markdown

A couple of updates:

@sternenseemann
haskell.packages.ghc910.stack: remove compat code
f94cecf 
Ideally, we won't use this going forward and just build stack with GHC 9.12
@sternenseemann

sternenseemann commented Jun 28, 2026

Copy link
Copy Markdown
Member Author

@mpilgrem Builds fine with your patches. Haven't tested much more yet since we don't (can't?) run the integration tests as part of the Nix build.

@sternenseemann
stack: drop released patch
f87fabd
@sternenseemann
stack: apply patches for semaphore-compat >= 2.0
f479cba 
Apply patches from commercialhaskell/stack#6935
allowing us to build stack with GHC 9.12.5-rc2 (but no other GHC version).
Patch for the change log is not included (due to likely conflict problems),
but other documentation included with stack is updated.

We also apply an unrelated bug fix, so we don't need to rebase the patches.
@sternenseemann sternenseemann changed the title [haskell-updates] stack: various cleanups, doesn't work yet [haskell-updates] stack: patch for semaphore-compat >= 2.0 Jul 1, 2026
wolfgangwalther
wolfgangwalther approved these changes Jul 2, 2026
View reviewed changes

@wolfgangwalther wolfgangwalther left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 534567 --additional-package tests.haskell.upstreamStackHpackVersion
Commit: f479cbacabc19e9d7e0d7e86cd4cd14315d7dc89

x86_64-linux

✅ 3 packages built:
  • haskellPackages.stack
  • stack
  • tests.haskell.upstreamStackHpackVersion

Comment thread pkgs/development/haskell-modules/configuration-common.nix
url = "https://github.com/commercialhaskell/stack/commit/591b6eb225b4cd2cfa4d282089fdb33e86bb14ad.patch";
hash = "sha256-GTUBGZ1KWQii60Yt9JpKcwMkzuIuSTdKLGd3aM0jXWw=";
})
# FIXME(@sternenseemann): these URLs are not stable (yet)

@wolfgangwalther wolfgangwalther Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these PRs will only be merged once a new stackage LTS release is made, I think we should probably not wait before merging this into, at least, haskell-updates.

@wolfgangwalther
wolfgangwalther added this pull request to the merge queue Jul 2, 2026
Merged via the queue into NixOS:haskell-updates with commit 9c55dbe Jul 2, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes
@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sternenseemann @mpilgrem @wolfgangwalther