Skip to content

flam3: fix license (gpl3Only, not cc-by-nc-sa-20)#95572

Merged
jtojnar merged 1 commit intoNixOS:masterfrom
raboof:nixpkgs-flam3
Aug 16, 2020
Merged

flam3: fix license (gpl3Only, not cc-by-nc-sa-20)#95572
jtojnar merged 1 commit intoNixOS:masterfrom
raboof:nixpkgs-flam3

Conversation

@raboof
Copy link
Copy Markdown
Member

@raboof raboof commented Aug 16, 2020 •
edited
Loading

https://github.com/scottdraves/flam3/blob/v3.1.1/COPYING

Motivation for this change

To be able to package qosmic without having to allow nonfree packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof raboof mentioned this pull request Aug 16, 2020
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 16, 2020
jtojnar
jtojnar reviewed Aug 16, 2020
View reviewed changes
@raboof raboof changed the title flam3: fix license (gpl3, not cc-by-nc-sa-20) flam3: fix license (gpl3Only, not cc-by-nc-sa-20) Aug 16, 2020
@raboof raboof force-pushed the nixpkgs-flam3 branch 5 times, most recently from 144350f to 1fc9cdc Compare August 16, 2020 11:42
@raboof raboof requested a review from jtojnar August 16, 2020 11:42
jtojnar
jtojnar reviewed Aug 16, 2020
View reviewed changes
pkgs/tools/graphics/flam3/default.nix Outdated
Copy link
Copy Markdown
Member

@jtojnar jtojnar Aug 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like gpl3Plus: https://github.com/scottdraves/flam3/search?q=license&unscoped_q=license

Copy link
Copy Markdown
Member Author

@raboof raboof Aug 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, you're quite right - the README doesn't specify 'any later version' but indeed each individual source file does.

Copy link
Copy Markdown
Member

@jtojnar jtojnar Aug 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, please ask them to update the website/readme.

Copy link
Copy Markdown
Member Author

@raboof raboof Aug 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, scottdraves/flam3#32

@raboof raboof requested a review from jtojnar August 16, 2020 12:02
@jtojnar jtojnar merged commit fc00e14 into NixOS:master Aug 16, 2020
@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Aug 16, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raboof @jtojnar