Add PF_W to PT_LOAD segment where the .dynamic section is placed#623
Open
Ponsuke07 wants to merge 1 commit intoNixOS:masterfrom
Open
Add PF_W to PT_LOAD segment where the .dynamic section is placed#623Ponsuke07 wants to merge 1 commit intoNixOS:masterfrom
Ponsuke07 wants to merge 1 commit intoNixOS:masterfrom
Conversation
This commit fix NixOS#146. In some binaries, the .dynamic section could be placed on a read-only PT_LOAD segment. Therefore, add a writable flag to PT_LOAD segment where the .dynamic section is placed. Signed-off-by: Daisuke Yamane <daisuke.yamane@miraclelinux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this PR
This PR fix #146.
In some binaries, the .dynamic section may be located in a read-only PT_LOAD segment.
Therefore, add a writable flag to the PT_LOAD segment in which the .dynamic section is located.
How to test
Use the repository from #146 (comment) to build a problematic binary:
After applying this PR, you will see that a writable flag(PF_W) has been added to the PT_LOAD section in which the .dynamic is located.
It also confirms that
make checktests pass.