Fix CE-014 - Webhook HMAC signature replay protection#103
Open
emdevelopa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix CE-014 - Webhook HMAC Signature Replay Protection
Description
This PR addresses issue CE-014 where the webhook HMAC signature lacked replay protection and documentation.
Changes
t=<unix_ts>\n<body>) to prevent replay attacks.x-nodus-signatureheader to include the timestamp (t=<timestamp>,v1=<hmac_hex>).docs/webhooks.mdwhich documents the signature verification steps, header format, signed payload structure, replay tolerance, and provides an example verification code in Python.tests/webhook_tests.rsto verify that signatures with valid timestamps pass, older signatures fail (replay protection), and signatures for tampered bodies fail.Impact
These changes ensure that interceptors cannot replay intercepted valid webhooks to trigger duplicate actions, enhancing the security of webhook endpoints for receivers.
closes #54