fix(plugin): dedupe final thinking snapshots#59
Open
qyhfrank wants to merge 1 commit intoNomadcxx:mainfrom
Open
fix(plugin): dedupe final thinking snapshots#59qyhfrank wants to merge 1 commit intoNomadcxx:mainfrom
qyhfrank wants to merge 1 commit intoNomadcxx:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
extractCompletionFromStream()sothinkingpartial deltas followed by a final accumulated event do not get duplicatedextractCompletionFromStream()with focused unit teststest:ci:unitWhy
The streaming converters already avoid duplicating final accumulated
thinkingframes after timestamped partial deltas, but the non-stream aggregation path insrc/plugin.tsstill appended the final accumulatedthinkingtext unconditionally. That left/chat/completionsnon-stream responses inconsistent with the streaming path and could duplicate reasoning text.Verification
bun test tests/unit/plugin-stream-extraction.test.tsbun run test:ci:unitbun run build