refactor(slang): spell a bytes push slot !sol.fixedbytes<1> - #638
Closed
hedgar2017 wants to merge 1 commit into
Closed
refactor(slang): spell a bytes push slot !sol.fixedbytes<1>#638hedgar2017 wants to merge 1 commit into
!sol.fixedbytes<1>#638hedgar2017 wants to merge 1 commit into
Conversation
The dialect casts `!sol.byte` and `!sol.fixedbytes<1>` as a no-op and the binder types a `bytes` element `bytes1`, so spelling the fixed-bytes form retires the byte constructor from the Rust vocabulary and the place path's byte/bytes1 branch with it. Blocked on solx-llvm unifying the two spellings' packed-storage canonicalization: until that lands, a pushed byte mis-packs against the byte-typed reader (`push_no_args_bytes.sol[a:4]`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #637. Retires
!sol.bytefrom solx's own vocabulary: thebytespush slot is spelled!sol.fixedbytes<1>(the binder'sbytes1), which deletes theMlirType::byteconstructor, its FFI binding, and the place path's byte/bytes1 branch —function_call_placetakes the binder's typing unconditionally.array_string_ops.solbecomes solx-only, since solc's print-init still types the slot!sol.byte.Blocked on solx-llvm unifying the byte/bytes1 packed-storage canonicalization: the two spellings cast as a no-op at value level, but the packing/cleanup arms (
EVMUtil.cppbyte exemptions, themstore8path) distinguish them in places, so until the dialect change lands a pushed byte mis-packs against the byte-typed reader —semanticTests/array/push/push_no_args_bytes.sol[a:4]fails on this branch, verified by execution. Index-access byte places stay C-derived viagetEltTypeand are untouched either way.Do not merge before the solx-llvm unification; re-run the full tester against it first.