updates for averaging fields#21
Merged
Merged
Conversation
This was referenced May 10, 2026
mvdebolskiy
reviewed
May 11, 2026
Comment on lines
+2251
to
+2252
| xaccum(jsea) = xaccum(jsea) + cos( ww3data(jsea) ) | ||
| yaccum(jsea) = yaccum(jsea) + sin( ww3data(jsea) ) |
Collaborator
There was a problem hiding this comment.
Will this ever work? You are accumulating angle and it does not loop 0-360. I am a bit confused.
Collaborator
Author
There was a problem hiding this comment.
@mvdebolskiy - I did not implement this - so this is a question for @anacarras. @anacarras - can you please give us some feedback here.
Collaborator
|
The wave directions variables (mean wave direction, swell direction and
wind sea direction) are given in degrees.
A direct average of the angles will give the wrong answer. So we did:
…-Convert to Components
-Average Components
-Reconvert to Angle by using arctangent2
Ana
On Mon, May 11, 2026 at 7:12 PM mvertens ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In model/src/wav_import_export.F90
<#21 (comment)>:
> + xaccum(jsea) = xaccum(jsea) + cos( ww3data(jsea) )
+ yaccum(jsea) = yaccum(jsea) + sin( ww3data(jsea) )
@mvdebolskiy <https://github.com/mvdebolskiy> - I did not implement this
- so this is a question for @anacarras <https://github.com/anacarras>.
@anacarras <https://github.com/anacarras> - can you please give us some
feedback here.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCN5LQ7M2RHQWLTTHBUX4D42ICWDAVCNFSM6AAAAACYX4PWFGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DENRVHAYDANBQGU>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
@anacarras yeah, it should never go into the edgecase of both xaccum and yaccum being zero, given the condition on counter. |
Collaborator
|
I did not think it was possible that both could be cero at the same time.
Am I wrong?
…On Mon, May 11, 2026 at 10:42 PM mvdebolskiy ***@***.***> wrote:
*mvdebolskiy* left a comment (NorESMhub/WW3#21)
<#21 (comment)>
@anacarras <https://github.com/anacarras> yeah, it should never go into
the edgecase of both xaccum and yaccum being zero, given the condition on
counter.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCN5LS3GOKIMPVNIQNPTSD42I3MXAVCNFSM6AAAAACYX4PWFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIMRVGAYTIMRXHE>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
You're right, it is possible that xaccum and yaccum are zero at the same
time.
I modified the program. Let me check if it compiles with no error. I am not
in Norway and I have difficulties connecting to Betzy. I will get back to
you.
Ana
…On Mon, May 11, 2026 at 11:36 PM Ana Carrasco ***@***.***> wrote:
I did not think it was possible that both could be cero at the same time.
Am I wrong?
On Mon, May 11, 2026 at 10:42 PM mvdebolskiy ***@***.***>
wrote:
> *mvdebolskiy* left a comment (NorESMhub/WW3#21)
> <#21 (comment)>
>
> @anacarras <https://github.com/anacarras> yeah, it should never go into
> the edgecase of both xaccum and yaccum being zero, given the condition on
> counter.
>
> —
> Reply to this email directly, view it on GitHub
> <#21 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACCN5LS3GOKIMPVNIQNPTSD42I3MXAVCNFSM6AAAAACYX4PWFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIMRVGAYTIMRXHE>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
mvdebolskiy
approved these changes
May 12, 2026
Collaborator
|
@anacarras it's not possible, since it from the same angle, unless the angle value is somehow poisoned. It's fine though. You don't need to modify anything. |
Collaborator
|
Awesome, thanks!
…On Tue, May 12, 2026 at 2:56 PM mvertens ***@***.***> wrote:
Merged #21 <#21> into noresm.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCN5LQ53G6CD5ROW2LFSZL42MNORAVCNFSM6AAAAACYX4PWFGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRVGQZTANZYGA3DGNA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
New fields to send to CMEPS to be written to cmeps auxiliary history files
Description
Need to following PRs to test:
cmeps: NorESMhub/CMEPS#48
ccs_config: NorESMhub/ccs_config_noresm#89
###Testing
./create_newcase --case <your_case> --compset 2000_DATM%JRA_SLND_SICE_SOCN_SROF_SGLC_WW3 --res TL319_ww3a --mach betzy --project <your_project> --run-unsupportedVerified that the resultant files
test_ww3.cpl.hx.wav.24h.avg.0001-01-02-00000.nccontained 5 time samples (for daily output) and that the output looked reasonable