Skip to content

LLT-6230: Introduce upper memory bound for async http code path#3

Merged
tomaszklak merged 3 commits intomasterfrom
memory-bound
Apr 7, 2026
Merged

LLT-6230: Introduce upper memory bound for async http code path#3
tomaszklak merged 3 commits intomasterfrom
memory-bound

Conversation

@tomaszklak
Copy link
Copy Markdown
Collaborator

@tomaszklak tomaszklak commented Apr 2, 2026

Before this change, it was possible for the malicious upnp gateway to trigger arbitrary large memory allocations on the client. This change caps the memory usage for both the HTTP headers and body.

@tomaszklak tomaszklak force-pushed the memory-bound branch 2 times, most recently from 61bdbcf to f8cefa3 Compare April 2, 2026 13:26
Copy link
Copy Markdown

@mathiaspeters mathiaspeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread src/common/tests.rs Outdated
Copy link
Copy Markdown

@sfraczek sfraczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread src/errors.rs
Comment thread src/common/tests.rs Outdated
Comment thread rust-toolchain
Add upper bound on the possible memory usage for http traffic, hardcoded
to 256KB.
macOS 15 introduced Local Network Access privacy restrictions that block
multicast/broadcast network access for unsigned, non-entitled processes
(like your test binary).

For more details see:
- github: actions/runner-images#10924
- apple: https://developer.apple.com/forums/thread/770473
@tomaszklak tomaszklak merged commit d45266b into master Apr 7, 2026
8 checks passed
@tomaszklak tomaszklak deleted the memory-bound branch April 7, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants