Upgrade wg nt#8
Closed
Hasan6979 wants to merge 38 commits intolibtelio-mainfrom
Closed
Conversation
…me-panic Fix last handshake time panic
use x25519_dalek instead of boringtun
Co-authored-by: Travis Athougies <travis@athougies.net>
This reverts commit 1b27c76.
This reverts commit 1d37da8.
The address was not translated correctly from byte array into Rust's Ipv6Addr. An IPv6 address when read from a continous byte array as u16 words will contain numbers in big endian. In order to make previous solution work one would need to call u16::from_be function to convert them into target's endianness before pasing them into the Ipv6Addr constructor. It's probably easier to just pass 16 elements long u8 array instead to avoid confusion. For this fix I've also reverted two previous commits that have tried to address this issue but unfortunately introduced another bug that was just a cover up for the first one. We were doing incorrect translations while setting and getting so in logs everything looked as expected, but the value in wg interface itself was wrong.
The `WireGuardGetConfiguration` returns peers with a set of flags. These flags contain the information if certain attributes like preshared key are present for the peer. This commit implements proper flags check before assinging attributes to the peer. Signed-off-by: Mateusz Szczygieł <mateusz.szczygiel@nordsec.com>
This commit includes two changes: - adds last OS error to a few returned errors - replace `log` crate with `tracing`
It was reported as such by clippy CI job
Without this change, the clippy job fails due to insufficient access right for the token. This is because the clippy-check wants to annotate PRs with a comments for each error and this requires write permissions for the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.