Skip to content

fix(eslint-config): allowed double quotes to avoid escaping to match … #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mineralsfree wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(eslint-config): allowed double quotes to avoid escaping to match … #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/eslint-config/__snapshots__/eslint.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,7 @@ exports[`ESLint Config Integrity > library config matches snapshot 1`] = `
"single",
{
"allowTemplateLiterals": true,
"avoidEscape": true,
},
],
"sonarjs/cognitive-complexity": [
Expand Down Expand Up @@ -1082,6 +1083,7 @@ exports[`ESLint Config Integrity > react config matches snapshot 1`] = `
"single",
{
"allowTemplateLiterals": true,
"avoidEscape": true,
},
],
"sonarjs/cognitive-complexity": [
Expand Down Expand Up @@ -1721,6 +1723,7 @@ exports[`ESLint Config Integrity > storybook config matches snapshot 1`] = `
"single",
{
"allowTemplateLiterals": true,
"avoidEscape": true,
},
],
"sonarjs/cognitive-complexity": [
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const baseConfig = defineConfig(
'no-console': 'off',
'no-prototype-builtins': 'off',
'no-unused-vars': 'off',
quotes: ['error', 'single', { allowTemplateLiterals: true }],
quotes: ['error', 'single', { allowTemplateLiterals: true, avoidEscape: true }],

@mzedel mzedel Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO backticks work for this purpose already...

'sonarjs/cognitive-complexity': ['error', 17],
'@typescript-eslint/ban-ts-comment': 'off',
'@typescript-eslint/member-ordering': ['error', { default: { order: 'alphabetically-case-insensitive' } }],
Expand Down