refactor(net): extract MockTimer into shared oath-adapter-net-mock crate (WS resilience PR0)#74
Conversation
Spec decomposes the ADR-0033 resilience stack into PRs 0-5 (PR6/tungstenite leaf roadmapped to its own spec); PR0 plan extracts MockTimer into a shared oath-adapter-net-mock crate per ADR-0034 §Amendments.4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughExtracts ChangesMockTimer extraction
Planning and design documentation
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related issues
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/superpowers/plans/2026-07-04-net-mock-extract.md`:
- Around line 27-33: The extraction plan is missing the manifest update for
oath-adapter-net-http-mock, so include crates/adapter/net/http/mock/Cargo.toml
in Task 1 alongside the existing lib.rs changes. Update the plan so it reflects
removal of oath-adapter-net-api from that crate’s dependencies and keeps the
file list accurate for the just machete/reachability checks; use the identifiers
oath-adapter-net-http-mock and oath-adapter-net-api to locate the affected task
scope.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 7e9e4f03-5cf1-4594-a5c5-fc6184b00cd1
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock,!**/*.lock
📒 Files selected for processing (9)
CHANGELOG.mdCargo.tomlcrates/adapter/net/http/mock/Cargo.tomlcrates/adapter/net/http/mock/src/lib.rscrates/adapter/net/mock/Cargo.tomlcrates/adapter/net/mock/src/lib.rscrates/adapter/net/mock/src/timer.rsdocs/superpowers/plans/2026-07-04-net-mock-extract.mddocs/superpowers/specs/2026-07-04-net-ws-resilience-design.md
💤 Files with no reviewable changes (1)
- crates/adapter/net/http/mock/Cargo.toml
Addresses CodeRabbit review on PR #74: Task 1 removes the orphaned oath-adapter-net-api dependency from oath-adapter-net-http-mock (only timer.rs used it), so the manifest is a modified file, not unchanged — the machete/reachability rationale now matches the diff. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Closes #73
PR0 of the net-ws resilience surface (spec: docs/superpowers/specs/2026-07-04-net-ws-resilience-design.md), mandated by ADR-0034 §Amendments.4.
oath-adapter-net-mockholdingMockTimer, beside theTimercontract inoath-adapter-net-api.MockTimermoved verbatim (history preserved viagit mv);oath-adapter-net-http-mocknow provides onlyMockClient/MockBody.MockTimerhad no consumers yet, so nothing external is repointed. Both mock crates keep thecargo tree -e no-dev -iproduction-reachability guard.This PR also lands the WS resilience design spec (docs/superpowers/specs/2026-07-04-net-ws-resilience-design.md) and this plan.
Generated with Claude Code
Summary by CodeRabbit
MockTimerfrom the HTTP mock package into the new shared mock package.