feat(gateway): Add log option to tool_progress setting#3458
Open
dlkakbs wants to merge 2 commits intoNousResearch:mainfrom
Open
feat(gateway): Add log option to tool_progress setting#3458dlkakbs wants to merge 2 commits intoNousResearch:mainfrom
dlkakbs wants to merge 2 commits intoNousResearch:mainfrom
Conversation
…ile instead of provider Adds a new `log` option to the `display.tool_progress` setting. When set, tool progress events are written to ~/.hermes/logs/tool_progress.log with timestamps instead of being sent to the gateway provider, enabling audit/ monitoring without messaging noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
logoption to the existingdisplay.tool_progresssetting.When set to
log, tool progress events are written to~/.hermes/logs/tool_progress.logwith timestamps instead of being sent to the gateway provider (Telegram, Discord, etc.). This enables full audit/monitoring of agent tool activity without cluttering the chat with progress messages.This is particularly useful for production or shared gateway deployments where you want visibility into what the agent is doing, but don't want intermediate tool updates appearing in the conversation.
Related Issue
#3450
Type of Change
Changes Made
gateway/run.py— Addedtool_progress_log_modeflag;progress_queueis skipped in log mode; added_append_tool_log()closure that writes timestamped entries to~/.hermes/logs/tool_progress.log;progress_taskonly started when there is an active queue (not in log mode)cli.py— Addedlogto the/verbosecycle (off → new → all → verbose → log → off) with a descriptive labelcli-config.yaml.example— Documented the newlogoption underdisplay.tool_progresshermes_cli/setup.py— Addedlogto the valid modes list and help text in the interactive setup wizardHow to Test
display.tool_progress: login~/.hermes/config.yaml~/.hermes/logs/tool_progress.log— each tool call should appear with a timestamp and previewlogmode via/verbosein the CLI and confirm the label readsTool progress: LOGChecklist
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass6180 tests collected, 1 pre-existing collection error in
tests/tools/test_mcp_tool.py(unrelated to this change)Documentation & Housekeeping
cli-config.yaml.exampleif I added/changed config keysPath.mkdir(parents=True, exist_ok=True)is cross-platform safe