Skip to content

QT prolongation Rmd file#32

Open
faribas wants to merge 21 commits into
masterfrom
QT
Open

QT prolongation Rmd file#32
faribas wants to merge 21 commits into
masterfrom
QT

Conversation

@faribas

@faribas faribas commented Mar 18, 2021

Copy link
Copy Markdown
Member

Check list for the page:

  • Check out to QT branch
  • review QT FK version
  • Provide comments
  • Dataset spec need to be updated
  • Run the page by Tim
  • Merge to master

@faribas faribas added the enhancement New feature or request label Mar 18, 2021
@faribas faribas closed this Mar 18, 2021
@faribas faribas reopened this Mar 18, 2021
@faribas faribas closed this Mar 18, 2021
@faribas faribas removed the request for review from iamstein March 18, 2021 15:49
xgxr_master_url = "https://raw.githubusercontent.com/Novartis/xgxr/master/"
source(paste0(xgxr_master_url, "R/xgx_stat_smooth.R"))
source(paste0(xgxr_master_url, "R/xgx_stat_ci.R"))

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need to be updated with lates package update


qt_data$SC <- qt_data$LIDV / median(qt_data$LIDV)
qt_data$AGE_GROUP = factor(cut(qt_data$AGE, 2), ordered = TRUE)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SC and AGE_GROUP haven't used in the code... delete?!

@faribas faribas reopened this Mar 18, 2021

@margoal1 margoal1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 20 files changed in this pull request. Can you remove all files, keeping only the QT prolongation Rmd and _site.yml files?
https://devconnected.com/how-to-remove-files-from-git-commit/

Comment thread Rmarkdown/_site.yml Outdated

- text: Resources
menu:
- text: Interactive Tutorial

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove tutorial, this is not ready yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants