Skip to content

Make generators configurable in map JSON files - #51

Merged
Gegy merged 3 commits into
NucleoidMC:1.17from
Genau6502:1.17
Sep 26, 2021
Merged

Make generators configurable in map JSON files#51
Gegy merged 3 commits into
NucleoidMC:1.17from
Genau6502:1.17

Conversation

@Genau6502

@Genau6502 Genau6502 commented Sep 25, 2021

Copy link
Copy Markdown
Contributor

This PR adds a generator field to all map config files. This allows fine-tuning of spawn chances and speeds of items in all generators, allowing for per-map balancing. This approach means that the overall increasing of rates in #41 is not needed - small maps can be tweaked to have slower generators and vice versa

Default generator speed as of before this PR:

"generator": {
    "level_1": {
      "gold": 2,
      "iron": 10,
      "spawn_interval_ticks": 34
    },
    "level_2": {
      "gold": 2,
      "iron": 10,
      "spawn_interval_ticks": 30
    },
    "level_3": {
      "gold": 9,
      "iron": 36,
      "emerald": 1,
      "spawn_interval_ticks": 26
    },
    "diamond": 1,
    "diamond_spawn_interval": 900,
    "emerald": 1,
    "emerald_spawn_interval": 1800
  }

@Gegy Gegy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh yay- thank you for this PR! This is a very much needed change, very excited to see what we can do with this new configuration in terms of balancing different maps!

Comment thread src/main/java/xyz/nucleoid/bedwars/game/BwMap.java
Comment thread src/main/java/xyz/nucleoid/bedwars/game/BwMapBuilder.java Outdated
Comment thread src/main/java/xyz/nucleoid/bedwars/game/active/BwActive.java Outdated
Comment thread src/main/java/xyz/nucleoid/bedwars/game/active/ItemGeneratorPool.java Outdated
Comment thread src/main/java/xyz/nucleoid/bedwars/game/active/ItemGeneratorPools.java Outdated
Comment thread src/main/java/xyz/nucleoid/bedwars/game/config/GeneratorConfig.java Outdated
@Gegy
Gegy merged commit 25d5e2f into NucleoidMC:1.17 Sep 26, 2021
@haykam821 haykam821 added the feature New feature or request label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants