Skip to content

Add id operand to search grammar. #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plural merged 2 commits into from
Mar 5, 2026
Merged

Add id operand to search grammar. #423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c711bb
Add id operand to search grammar.
plural Mar 5, 2026
52f2f01
Fix lint
plural Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/search_query_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,9 @@ def self.both(field)
FieldData.new(:string, both('stripped_text'), %w[text x],
'The text of a card, stripped of all formatting symbols and marks.'),
FieldData.new(:string, both('stripped_title'), %w[title _],
'The title of a card, stripped of all formatting symbols and marks.')
'The title of a card, stripped of all formatting symbols and marks.'),
FieldData.new(:string, both('id'), %w[id],
'The string id for this type.')
]
# rubocop:enable Layout/LineLength
def self.search_filter_docs
Expand Down Expand Up @@ -324,7 +326,7 @@ def initialize(query)
end

# Generate SQL query and parameters from AST
# This has the side effect of adding the SQL parameters to @where_values
# This has the side effect of adding the SQL parameters to @whereues
@where_values = []
# TODO(plural): Capture any exceptions in here and return them as well formatted errors.
@where = transform.apply(@parse_tree).construct_clause(@where_values, fields)
Expand Down Expand Up @@ -462,7 +464,7 @@ def construct_clause(parameters, context)

# Booleans
when :boolean
unless %w[true false t f 1 0].include?(value)
unless %w[true false t f 1 0 any].include?(value)
raise format('Invalid value "%<value>s" for boolean field "%<field>s"', value:, field: context.keyword)
end

Expand Down