Fail fast on empty auth credentials; log real device instance creation errors - #138
Merged
Merged
Conversation
…n errors Previously, if the server approved a device but sent no AppId/AppSecret (e.g. device already marked authorized server-side but the client's local secret store was cleared), the client silently accepted the approval and only failed later in send_authenticate with a vague "AppId not set", causing an infinite reconnect loop instead of surfacing a clear error. await_authorization now falls back to cached credentials and fails immediately if none are available, routing into the existing error-state path. Also, add_device_instance previously swallowed the real error from create_device_instance behind a generic "Failed to create device instance" status. It's now logged alongside the generic client-facing message for easier diagnosis. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the server approved a device but sent no AppId/AppSecret (e.g. device already marked authorized server-side but the client's local secret store was cleared), the client silently accepted the approval and only failed later in send_authenticate with a vague "AppId not set", causing an infinite reconnect loop instead of surfacing a clear error. await_authorization now falls back to cached credentials and fails immediately if none are available, routing into the existing error-state path.
Also, add_device_instance previously swallowed the real error from create_device_instance behind a generic "Failed to create device instance" status. It's now logged alongside the generic client-facing message for easier diagnosis.