Omit thunk in class-based resources when not needed

[gossi]

When using a Resource but not using arguments with reactive parameters, then initializing them, so far still required the usage of a thunk, ie:

class TestResource extends Resource {
  foo = 3;
}

class Test {
  data = TestResource.from(this, () => []);
}

... for basically, no reason. This PR makes thunks a non-required parameter, leading into cleaner code like so:

class TestResource extends Resource {
  foo = 3;
}

class Test {
  data = TestResource.from(this);
}

:)

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[changeset-bot]

🦋 Changeset detected

Latest commit: d656eb4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
ember-resources	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gossi]

that overload makes the type tests fail.. ie, when this is a thunk, then the types are not checked against the args from signature. This needs to stay intact.

Also for me it is late in the eve right now and I will postpone this

[gossi]

My alternative solution wasn't working either:

  static from<SomeResource extends Resource<any>, CT = unknown>(
    this: Constructor<SomeResource>,
    contextOrThunk: CT extends Function ? AsThunk<ArgsFrom<SomeResource>> : unknown
  ): SomeResource;

[gossi]

As an attempt to work with more specific types, we (Jan and me) tried to give the Context its own type. That is, we started with unknown but stopped with object, the reason is, that destroyable accepts an object at

ember-resources/ember-resources/src/util/map.ts

Line 170 in 6fc67cb

destroyable: object,

Maybe Context can be such a type:

type Context = Exclude<object, Thunk>;

[gossi]

As a result for Context being very broadly typed due to destroyable (linked above), this required a second generic parameter here to test against. Basically, the same condition used in the code:

ember-resources/ember-resources/src/core/class-based/resource.ts

Line 268 in 6fc67cb

if (typeof contextOrThunk === 'function') {

but here on type-level.

[NullVoxPopuli]

yeah, function vs object typings are hard :(

[NullVoxPopuli]

thank a ton for such a thorough changelog entry!

[NullVoxPopuli]

Suggested change

	When using a `Resource` but not using arguments with reactive parameters, initializing them still required the usage of a thunk, ie:
	When using the class-based `Resource` without reactive parameters, initializing _used to_ require the usage of a thunk, ie:

[NullVoxPopuli]

Suggested change

	... for basically, no reason. This change makes thunks a non-required parameter, leading into cleaner code like so:
	This change makes thunks a non-required parameter, leading into cleaner code like so: