Skip to content

[codex] Allow ocean-only sea ice model without atmosphere#269

Open
taimoorsohail wants to merge 11 commits into
mainfrom
ts/allow-sea-ice-ocean-only-model
Open

[codex] Allow ocean-only sea ice model without atmosphere#269
taimoorsohail wants to merge 11 commits into
mainfrom
ts/allow-sea-ice-ocean-only-model

Conversation

@taimoorsohail
Copy link
Copy Markdown
Collaborator

Summary

  • allow OceanSeaIceModel no-atmosphere runs to use typed zero rainfall and snowfall inputs
  • route ocean and sea-ice net flux assembly through dispatch instead of dereferencing atmosphere state directly
  • preserve the existing NoAtmosInterfaceModel no-op interface flux behavior for ocean-only sea-ice coupling

Why

The constructor path already allows atmosphere=nothing, but the net-flux assembly still assumed an atmosphere exchanger and crashed when prognostic sea ice was present. This change makes the no-atmosphere path consistent with the existing type-based coupling design.

Closes #268

Validation

  • Local tests not run, per repository instructions to leave test execution to GitHub CI.

@taimoorsohail taimoorsohail marked this pull request as ready for review May 21, 2026 07:07
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

@josuemtzmo josuemtzmo mentioned this pull request May 21, 2026
@taimoorsohail
Copy link
Copy Markdown
Collaborator Author

OK the hard-coded assumptions of valid atmosphere stretch a lot further than I anticipated. This will take a bit to work on and merge, especially wrangling the weird CUDA errors.

@simone-silvestri
Copy link
Copy Markdown
Member

I think we only need to change the assemble functions right? The flux computation should return nothing if there is no atmosphere.

Comment thread src/EarthSystemModels/InterfaceComputations/atmosphere_ocean_fluxes.jl Outdated
Comment thread src/EarthSystemModels/InterfaceComputations/atmosphere_sea_ice_fluxes.jl Outdated
Comment thread src/SeaIces/assemble_net_sea_ice_fluxes.jl Outdated
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Comment thread src/EarthSystemModels/InterfaceComputations/atmosphere_ocean_fluxes.jl Outdated
@navidcy
Copy link
Copy Markdown
Member

navidcy commented May 22, 2026

Is this captured by any test or doctest?

@navidcy navidcy self-requested a review May 23, 2026 00:12
@navidcy
Copy link
Copy Markdown
Member

navidcy commented May 23, 2026

Is this captured by any test or doctest?

a92ff45 added one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OceanSeaIceModel() default atmosphere=nothing not supported

3 participants