[codex] Allow ocean-only sea ice model without atmosphere#269
Open
taimoorsohail wants to merge 11 commits into
Open
[codex] Allow ocean-only sea ice model without atmosphere#269taimoorsohail wants to merge 11 commits into
taimoorsohail wants to merge 11 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
simone-silvestri
approved these changes
May 21, 2026
Merged
Collaborator
Author
|
OK the hard-coded assumptions of valid atmosphere stretch a lot further than I anticipated. This will take a bit to work on and merge, especially wrangling the weird CUDA errors. |
Member
|
I think we only need to change the |
navidcy
reviewed
May 22, 2026
navidcy
reviewed
May 22, 2026
navidcy
reviewed
May 22, 2026
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
navidcy
reviewed
May 22, 2026
Member
|
Is this captured by any test or doctest? |
navidcy
approved these changes
May 23, 2026
Member
a92ff45 added one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OceanSeaIceModelno-atmosphere runs to use typed zero rainfall and snowfall inputsNoAtmosInterfaceModelno-op interface flux behavior for ocean-only sea-ice couplingWhy
The constructor path already allows
atmosphere=nothing, but the net-flux assembly still assumed an atmosphere exchanger and crashed when prognostic sea ice was present. This change makes the no-atmosphere path consistent with the existing type-based coupling design.Closes #268
Validation