test: skip quoting-engine strategy tests when private module is absent#10
Open
shuofengzhang wants to merge 1 commit intoNunchi-trade:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
requires_quoting_engineskip marker intests/test_engine_strategies.pythat checks whether~/Tee-work-/quoting_engineexists.engine_mm,funding_arb,regime_mm,liquidation_mm).Why
quoting_enginecheckout, even though the repo documents open-source alternatives.Insight / Why this matters
ImportErrorwhen a local private path (~/Tee-work-/quoting_engine) is absent.Practical gain / Why this matters
pytestis no longer blocked by private-only imports in standard OSS environments.quoting_enginechecked out.Testing
scripts/clone_and_test.sh Nunchi-trade/agent-cli20 failed, 580 passed(failures due to missing~/Tee-work-/quoting_engine).source .venv/bin/activate && pytest -q tests/test_engine_strategies.py3 passed, 20 skippedscripts/clone_and_test.sh Nunchi-trade/agent-cli580 passed, 20 skippedRisk analysis