Skip to content

[19.0][IMP] Update analysis files#5828

Merged
MiquelRForgeFlow merged 3 commits into
19.0from
19.0-update-analysis-bot
Jul 21, 2026
Merged

[19.0][IMP] Update analysis files#5828
MiquelRForgeFlow merged 3 commits into
19.0from
19.0-update-analysis-bot

Conversation

@github-actions

Copy link
Copy Markdown

Analysis or noupdate changes for modules marked as done:

  • account
  • base
  • hr_holidays
  • project
  • uom

@hbrunn

hbrunn commented Jul 21, 2026

Copy link
Copy Markdown
Member

@MiquelRForgeFlow why did you force push here instead of adding a separate commit? This needs to be redone now that ocabot force pushed over it yesterday.

And this should be regenerated anyways once OCA/server-tools#3677 is merged

@hbrunn

hbrunn commented Jul 21, 2026

Copy link
Copy Markdown
Member

I've triggered a new analysis run - @MiquelRForgeFlow when this is done, please push your changes as new commit, then we can merge this

@github-actions
github-actions Bot force-pushed the 19.0-update-analysis-bot branch from fbb1459 to a234cc7 Compare July 21, 2026 10:27
Comment thread openupgrade_scripts/scripts/account/19.0.1.4/noupdate_changes.xml
@MiquelRForgeFlow
MiquelRForgeFlow requested a review from hbrunn July 21, 2026 11:35
@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

My commit handles odoo/odoo@9292854.

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

@hbrunn is it ok for you my commit?

@hbrunn

hbrunn commented Jul 21, 2026

Copy link
Copy Markdown
Member

in light of the commit you link, shouldn't we remove

def rating_project_request_email_template_active(env):
"""
Set project.rating_project_request_email_template's active flag based on rating
being active for some task type
"""
env.ref("project.rating_project_request_email_template").active = bool(
env["project.task.type"].search([("rating_active", "=", True)])
)
too?

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

Nice finding.

The project module's own migration script already sets
rating_project_request_email_template.active = True, so there is no need
for OpenUpgrade to handle it. Load the full noupdate_changes.xml (drop
the transformation that stripped the active field) and remove the now
redundant rating_project_request_email_template_active post-migration
function.
@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the 19.0-update-analysis-bot branch from 7767918 to 6b8e81b Compare July 21, 2026 13:46
@MiquelRForgeFlow
MiquelRForgeFlow merged commit 3d783c0 into 19.0 Jul 21, 2026
6 of 7 checks passed
@OCA-git-bot
OCA-git-bot deleted the 19.0-update-analysis-bot branch July 21, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants