Skip to content

[17.0][FIX] agrement_legal: Fix duplicated clauses #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palomagrc93 wants to merge 1 commit into
base: 17.0
Choose a base branch
from
+17 −1
Open

[17.0][FIX] agrement_legal: Fix duplicated clauses #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion agreement_legal/models/agreement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,8 +520,23 @@ def copy(self, default=None):
default = dict(default or {})
if not default.get("code", False):
default.setdefault("code", _("New"))
# Prevent automatic clause copy through sections to avoid duplication.
default.setdefault("sections_ids", [])
res = super().copy(default)
res.sections_ids.mapped("clauses_ids").write({"agreement_id": res.id})
section_map = {}
for section in self.sections_ids:
new_section = section.copy(
{
"agreement_id": res.id,
"clauses_ids": False,
}
)
section_map[section.id] = new_section.id
for clause in self.clauses_ids:
values = {"agreement_id": res.id}
if clause.section_id:
values["section_id"] = section_map.get(clause.section_id.id)
clause.copy(values)
return res

def _exclude_readonly_field(self):
Expand Down
1 change: 1 addition & 0 deletions agreement_legal/tests/test_create_agreement_wizard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def test_create_agreement(self):
self.assertEqual(agreement.is_template, False)
self.assertEqual(agreement.recital_ids.name, template.recital_ids.name)
self.assertEqual(agreement.sections_ids.name, template.sections_ids.name)
self.assertEqual(len(agreement.clauses_ids), len(template.clauses_ids))
self.assertEqual(agreement.clauses_ids.name, template.clauses_ids.name)
self.assertEqual(agreement.clauses_ids.section_id, agreement.sections_ids)
self.assertEqual(agreement.appendix_ids.name, template.appendix_ids.name)
Loading