Skip to content

[IMP] uom_unece: cache UNECE code mapping#270

Merged
OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:16.0-uom_unece-sbj
May 11, 2026
Merged

[IMP] uom_unece: cache UNECE code mapping#270
OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:16.0-uom_unece-sbj

Conversation

@sbejaoui
Copy link
Copy Markdown
Contributor

@sbejaoui sbejaoui commented Mar 25, 2026

add an ormcache based helper to map UNECE codes to UoM

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 25, 2026

Hi @alexis-via, @astirpe,
some modules you are maintaining are being modified, check this out!

@sbejaoui
Copy link
Copy Markdown
Contributor Author

sbejaoui commented Mar 25, 2026 •
edited
Loading

cc/ @lmignon , @jbaudoux

@sbejaoui sbejaoui force-pushed the 16.0-uom_unece-sbj branch 2 times, most recently from c8deb01 to 95aa704 Compare March 25, 2026 09:48
@sbejaoui sbejaoui changed the title [IMP] uom_unece: [IMP] uom: cache UNECE code mapping [IMP] uom_unece: cache UNECE code mapping Mar 25, 2026
@sbejaoui sbejaoui mentioned this pull request Mar 25, 2026
Open
@sbejaoui sbejaoui force-pushed the 16.0-uom_unece-sbj branch from 95aa704 to 9c38a11 Compare March 25, 2026 11:36
@sbejaoui
[IMP] uom_unece: cache UNECE code mapping
fb8b0ff 
add an ormcache based helper to map UNECE codes to UoM
@sbejaoui sbejaoui force-pushed the 16.0-uom_unece-sbj branch from 9c38a11 to fb8b0ff Compare March 25, 2026 11:38
@alexis-via
Copy link
Copy Markdown
Contributor

alexis-via commented Apr 27, 2026

Looks great ! I suppose you implemented this to improve perfs ; why did you implement it specifically here ? There are some many odoo data that could be cached to improve perf... why target this particular module? I'm just curious...

@rrebollo
Copy link
Copy Markdown

rrebollo commented Apr 30, 2026

@sbejaoui please prefix the PR title with [16.0] ...

rrebollo
rrebollo approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review. LGTM!

Would you be so kind to review mine in return? #241

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 30, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bosd
bosd approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lmignon
Copy link
Copy Markdown

lmignon commented May 11, 2026

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 11, 2026

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-270-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cf38da0 into OCA:16.0 May 11, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 11, 2026

Congratulations, your PR was merged at 0a71f8c. Thanks a lot for contributing to OCA. ❤️

@bosd bosd mentioned this pull request May 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmignon lmignon lmignon approved these changes

+2 more reviewers

@bosd bosd bosd approved these changes

@rrebollo rrebollo rrebollo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sbejaoui @OCA-git-bot @alexis-via @rrebollo @lmignon @bosd