[19.0][MIG] Port connector#528
Closed
YoussefEgla wants to merge 1 commit into
Closed
Conversation
845a81a to
77d6f2e
Compare
10b46fc to
436b157
Compare
436b157 to
eeba0fb
Compare
eeba0fb to
1f1c5c8
Compare
Contributor
|
Thanks for your contrib but component modules are already migrated and connector is pending here #511 since a while. You could help w/ a review if you want ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the
component,component_event, andconnectorframework addons from 18.0 to 19.0.To keep review manageable, the history is intentionally split in 2 commits:
Copy component framework addons from 18.0Apply Odoo 19 porting changesThis allows reviewers to inspect the first commit as a straight copy and focus on the second commit for the actual 19.0 delta.
What was changed
component
The
componentaddon needed one real runtime adaptation for Odoo 19 and a test compatibility fix:ModuleGraphAPI in the component builder.component_event
The
component_eventaddon did not require functional runtime changes, but it needed Odoo 19 compatibility updates in metadata and tests:MetaCase, which is no longer available in Odoo 19.Runtime behavior of the addon itself remains the same: event collection, listener dispatch, and base model hooks continue to work unchanged on top of the ported
componentaddon.connector
The
connectoraddon required a small but important Odoo 19 data-model update plus test adjustments:env.contextmutation.res.groupsmodel:res.groups.privilegeprivilege_iduserswithuser_idsWhy these changes are needed
This port mainly addresses three Odoo 19 compatibility areas:
MetaCasepattern is no longer availableres.groups, which now rely on privileges instead of the old category-based setup used in addon XML.Functional scope
These addons are framework addons rather than business-feature addons, so validation focused on the framework behaviors they provide:
work_on(...)behaviorNo migration scripts were needed because the port is focused on framework compatibility and install and runtime behavior on Odoo 19.
Validation performed
component
Manual Odoo shell checks passed for the component framework after installation, including basic registry, build, and component lookup behavior.
component_event
Manual Odoo shell smoke test passed.
Shell snippet used:
Observed output:
This validated:
_event(...).notify(...)on_record_createon_record_writeon_record_unlinkconnector
Manual Odoo shell smoke test passed.
Shell snippet used:
Observed output:
This validated:
queue.jobextensioncomponent_eventno_connector_exportis set in contextNote: the info log produced by the record locker during the smoke test is expected, because the test intentionally exercises the retry path for concurrent locking.
Notes for reviewers