[19.0] [MIG] contract: Migration to 19.0 by BhaveshHeliconia · Pull Request #1312 · OCA/contract

BhaveshHeliconia · 2025-10-01T09:21:06Z

No description provided.

tishmen · 2025-10-17T00:35:33Z

@BhaveshHeliconia can you please handle the failing tests so we can push this forward?

mamcode · 2025-10-27T00:28:59Z

@BhaveshHeliconia could you please re-run the CI checks?
I’ve tested locally with the latest ghcr.io/oca/oca-ci:py3.11-19.0 image, and it seems the CI is using an outdated cache because I am getting different errors from unit tests.

BhaveshHeliconia · 2025-11-12T12:11:37Z

@tishmen @mamcode : CI is green now. Thanks!

pedrobaeza · 2025-11-19T15:37:57Z

/ocabot migration contract

Please cherry-pick #1343

BhaveshHeliconia · 2025-11-20T05:04:34Z

/ocabot migration contract

Please cherry-pick #1343

@pedrobaeza : Done. Thanks!

BhaveshHeliconia · 2025-11-21T04:30:07Z

@pedrobaeza : I’ve completed all the changes you recommended. Thanks for the feedback!

pedrobaeza · 2025-11-24T07:29:20Z

Please include #1341

BhaveshHeliconia · 2025-11-25T05:06:21Z

Please include #1341

Done. Thanks!

…journal

…o translate

…y 'test'" error

…ing onchanges When copying values from the contract template, skip assignment if the value is already the same on the contract. This prevents triggering unnecessary onchanges without altering the behavior.

…based rules

…ct lines This field is unused in this module, but in the contract_sale_invoicing module it is used to search Sales Orders. However, many times this field goes unnoticed and users set the analytic distribution directly on the lines. After this commit, the field is computed automatically based on the contract lines.

…act lines

… does not have access TT59505

On portal, the cancelled lines are not distinguished from running ones, as the next invoice date is still displayed, and the color is the same (on contrary than the backend, that appears greyed). So let's do something similar in portal: - Put the row as grey. - Hide the nexte invoice date on that case. TT59704

…upport

BhaveshHeliconia · 2026-05-13T04:47:03Z

@carlos-lopez-tecnativa thanks for the review. I’ve addressed your comments.

bosd · 2026-05-13T11:47:07Z

Hello @sbidoul , @AaronHForgeFlow , sorry for pinging you directly, can you pls trigger merge here?

MohamedOsman7

Tested with runboat, LGTM

carlos-lopez-tecnativa

In my previous comment, I suggested squashing the administrative commits for the same language and the same author, but I noticed that you squashed commits that should not have been squashed and merged them into the previous commit, losing the original author. Please review this and rework the Git history correctly.

You can read this documentation if it helps:
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

carlos-lopez-tecnativa · 2026-05-13T13:39:02Z

+        invoices |= self.env["account.move"].search(
+            [("old_contract_id", "=", self.ids)]
+        )


I’m not sure if this issue is caused by this change, but please check it.

In v19, when you create a new contract without a customer, the invoice count is incorrect. This causes the Recurrence at line level field to become readonly because invoice_count != 0.

In v18, this works fine.

Additionally, if you pass a list of IDs, the operator should be in instead of =. Please clarify the reason for this change.

Done. Changed to in to correctly handle NewId in Odoo 19. This fixes the incorrect count for new contracts and keeps the recurrence field editable. Thanks!

I squashed all translation-related commits together, but I understand now that some commits should have remained separate to preserve the original authorship. I'll rework the Git history accordingly and add it to my TODO list.

Yes, you should only merge translation commits coming from the same author, not all the translations commits together.

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from 877c2f7 to 8f589c2 Compare October 1, 2025 10:12

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 2 times, most recently from b18f362 to 885e5a6 Compare October 8, 2025 12:17

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 5 times, most recently from a38846e to c99f54f Compare October 17, 2025 03:57

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from c99f54f to 983c9c2 Compare October 27, 2025 06:11

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 2 times, most recently from a653227 to 3251a90 Compare November 12, 2025 12:05

OCA-git-bot added this to the 19.0 milestone Nov 19, 2025

OCA-git-bot mentioned this pull request Nov 19, 2025

Migration to version 19.0 #1310

Open

27 tasks

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from 3251a90 to a3218c0 Compare November 20, 2025 05:01

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from a3218c0 to b57bad9 Compare November 20, 2025 05:11

pedrobaeza reviewed Nov 20, 2025

View reviewed changes

Comment thread contract/models/contract_template_line.py Outdated

Comment thread contract/tests/test_contract.py Outdated

Comment thread contract/tests/test_contract.py Outdated

Comment thread contract/tests/test_portal.py Outdated

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 2 times, most recently from 65801a9 to 4ce03c5 Compare November 21, 2025 04:27

pedrobaeza reviewed Nov 21, 2025

View reviewed changes

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 2 times, most recently from b527c46 to 4e377c2 Compare November 21, 2025 09:51

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from 4e377c2 to 8cddba3 Compare November 25, 2025 05:01

rousseldenis and others added 22 commits May 13, 2026 10:10

[IMP] contract: Use account.journal _check_company_domain() to get …

4766be9

…journal

[IMP] contract: Remove wrong api.model decorators + use Environment t…

4ead08a

…o translate

[IMP] contract: remove blocking view in migration script

bbd692a

[IMP] contract and product_contract: pre-commit auto fixes

1a23f6c

[IMP] contract: make label for notes visible on contract view form

b578f83

[FIX] contract: Remove test flag from contract because of "unknown ke…

714bf89

…y 'test'" error

[OU-FIX] contract: migration scripts

d8262ae

[IMP] Contract line: compute display name

a3427f2

[FIX] contract.recurring_create_invoice: Add ensure_one

0862c12

[IMP] contract: skip assignment when value unchanged to avoid trigger…

bba6520

…ing onchanges When copying values from the contract template, skip assignment if the value is already the same on the contract. This prevents triggering unnecessary onchanges without altering the behavior.

[FIX] contract: automatic pricing should resptect pricelist quantity-…

755089c

…based rules

[18.0][IMP] contract: hook for line is invoiceable

959fc38

[IMP] contract: store additional fields for analysis purposes

56f357c

[IMP] contract: enhance search filters and add a pivot view for contr…

2eab7d1

…act lines

[FIX] contract: Avoid the error when accessing the portal if the user…

781411a

… does not have access TT59505

[IMP] contract: add paths to actions

96988d7

[FIX] contract: Use another condition for forcingn a failure

6cc2651

[18.0][IMP] contract: Improve contract lines view with section/note s…

d7959ec

…upport

[FIX] contract : ignore date constraint for a note

f2862d3

[IMP] contract: pre-commit auto fixes

35ac0f5

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from dd55d88 to 5923b16 Compare May 13, 2026 04:40

MohamedOsman7 approved these changes May 13, 2026

View reviewed changes

MohamedOsman7 mentioned this pull request May 13, 2026

[19.0][MIG] contract_line_successor #1370

Open

carlos-lopez-tecnativa suggested changes May 13, 2026

View reviewed changes

[MIG] contract: Migration to 19.0

97c88f7

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from 5923b16 to 97c88f7 Compare May 15, 2026 05:09

Uh oh!

Conversation

BhaveshHeliconia commented Oct 1, 2025

Uh oh!

tishmen commented Oct 17, 2025

Uh oh!

mamcode commented Oct 27, 2025

Uh oh!

BhaveshHeliconia commented Nov 12, 2025

Uh oh!

pedrobaeza commented Nov 19, 2025

Uh oh!

BhaveshHeliconia commented Nov 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BhaveshHeliconia commented Nov 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pedrobaeza commented Nov 24, 2025

Uh oh!

BhaveshHeliconia commented Nov 25, 2025

Uh oh!

BhaveshHeliconia commented May 13, 2026

Uh oh!

bosd commented May 13, 2026

Uh oh!

MohamedOsman7 left a comment

Choose a reason for hiding this comment

Uh oh!

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

carlos-lopez-tecnativa May 13, 2026

Choose a reason for hiding this comment

Uh oh!

carlos-lopez-tecnativa May 13, 2026

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia May 15, 2026

Choose a reason for hiding this comment

Uh oh!

pedrobaeza May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants