Conversation
etobella
force-pushed
the
19.0-mig-mail
branch
from
c598e9c to
9b4f48e
Compare
etobella
force-pushed
the
19.0-mig-mail
branch
from
9b4f48e to
a88067b
Compare
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
Interesting approach! Thanks!
| @@ -0,0 +1 @@ | |||
| This module allows to process mails received as edi.exchange.records to process them. | |||
There was a problem hiding this comment.
maybe add a configuration file?
| attachment.fname, | ||
| re.IGNORECASE, | ||
| ): | ||
| content = self._process_email_attachment(attachment) |
There was a problem hiding this comment.
I cannot find this method in Odoo 🤔
There was a problem hiding this comment.
|
|
||
| class EdiExchangeType(models.Model): | ||
| _name = "edi.exchange.type" | ||
| _inherit = ["edi.exchange.type", "mail.alias.mixin"] |
There was a problem hiding this comment.
Thinking out loud: instead of polluting the exchange type model, wouldn't be interesting to have a specific record for this? Eg: "EDI mail gateway" or something similar.
Easier to maintain and to configure for the end user probably. WDYT?
There was a problem hiding this comment.
Or maybe using edi.backend. At the end, that is the goal of backends, isn't it?
etobella
force-pushed
the
19.0-mig-mail
branch
from
c4338c9 to
c52a31e
Compare
Remove unnecessary sudo
etobella
force-pushed
the
19.0-mig-mail
branch
from
c52a31e to
12991dd
Compare
etobella
force-pushed
the
19.0-mig-mail
branch
from
8b6c81b to
82e92fb
Compare
|
@simahawk After your comments, I do agree that the best approach would be to set everything on the backend and do the same thing we do with Storage. Also, I improved REadmes and information inside the backend to make it easier to handle (actually, it would be nice to include similar information in other modules to make it easier for users. Thanks for your comments, IMO they improved the solution. 
|
2 participants
Depends on #215