[19.0][MIG] edi_purchase_oca: Migration to 19.0#270
[19.0][MIG] edi_purchase_oca: Migration to 19.0#270
Conversation
yankinmax
force-pushed
the
19.0-mig-edi_purchase_oca
branch
2 times, most recently
from
b915a4d to
c65991f
Compare
yankinmax
force-pushed
the
19.0-mig-edi_purchase_oca
branch
4 times, most recently
from
895a472 to
0d0e8b4
Compare
|
This PR has the |
|
@etobella could we get a merge here? |
|
@simahawk could you take a look here? Thanks! |
|
Hello @OCA/edi-framework-maintainers can you pls take a look and possibly trigger merge? |
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
@yankinmax if you need help let me know.
| ) | ||
| yield | ||
| # edi_record_metadata api | ||
| def _edi_get_metadata_to_store(self, orig_vals): |
There was a problem hiding this comment.
Sorry but there are too many changes in the migration commit.
These changes should not be part of the migration only...
This is a whole refactoring for alignment w/ edi_sale_oca.
There was a problem hiding this comment.
I thought it would be useful. Should I get back the changes just to have what was here?
| "purchase", | ||
| "edi_core_oca", | ||
| "edi_record_metadata_oca", | ||
| "edi_component_oca", |
There was a problem hiding this comment.
you are getting rid of listeners but adding edi_component_oca here? 🤔
There was a problem hiding this comment.
I thought this is the idea requested here:
#180 (comment)
| Define EDI Configuration for Purchase Orders""", | ||
| "version": "18.0.1.0.0", | ||
| "version": "19.0.1.0.0", | ||
| "development_status": "Alpha", |
There was a problem hiding this comment.
why getting back to Alpha? Default is Beta.
There was a problem hiding this comment.
Run manifestoo -d . check-dev-status --default-dev-status=Beta
edi_purchase_oca (Beta) depends on edi_record_metadata_oca (Alpha)
Error: Process completed with exit code 1.
But, we can go just with a migration and won't have this error
[UPD] Update edi_purchase_oca.pot [UPD] README.rst
[UPD] Update edi_purchase_oca.pot [UPD] README.rst [UPD] Update edi_purchase_oca.pot [UPD] Update edi_purchase_oca.pot [UPD] Update edi_purchase_oca.pot [UPD] README.rst
Translated using Weblate (Spanish) Currently translated at 100.0% (19 of 19 strings) Translation: edi-14.0/edi-14.0-edi_purchase_oca Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-edi_purchase_oca/es/
| <field name="type_id" ref="demo_edi_exc_type_order_out" /> | ||
| <field name="backend_id" ref="demo_edi_backend" /> | ||
| <field name="model_id" ref="purchase.model_purchase_order" /> | ||
| <field name="trigger_id" ref="edi_conf_trigger_purchase_order_state_change" /> |
There was a problem hiding this comment.
Hello @simahawk
edi_conf_trigger_purchase_order_state_change is added as a change you've pointed too.
edi_component_oca extends edi.exchange.consumer.mixin.write to emit those generic state change events.
I thought you've pointed too use this in this suggestion:
#180 (comment)
yankinmax
force-pushed
the
19.0-mig-edi_purchase_oca
branch
3 times, most recently
from
826377f to
106926c
Compare
yankinmax
force-pushed
the
19.0-mig-edi_purchase_oca
branch
from
106926c to
313284b
Compare
12 participants
This is a migration which:
edi_sale_oca: https://github.com/OCA/edi-framework/tree/18.0/edi_sale_oca