[18.0][FIX] account_invoice_import: Use correct fiscal position#1302
Open
mt-software-de wants to merge 1 commit into
Open
[18.0][FIX] account_invoice_import: Use correct fiscal position#1302mt-software-de wants to merge 1 commit into
mt-software-de wants to merge 1 commit into
Conversation
Contributor
|
Hi @alexis-via, |
mt-software-de
changed the title
mt-software-de
force-pushed
the
18-fix-account_invoice_import-fiscal_position
branch
from
2103d7d to
e83c606
Compare
arnaudlayec
suggested changes
Mar 11, 2026
Contributor
There was a problem hiding this comment.
Hello,
Thank you for this change. I agree it is really needed because in previous code, if partner.property_account_position_id is empty, the fiscal position of the invoice can be set wrongly.
A call to the native method res_partner._get_fiscal_position should indeed replace the partner.property_account_position_id
I have a few suggestions to let the code simple to read
arnaudlayec
reviewed
Mar 12, 2026
mt-software-de
force-pushed
the
18-fix-account_invoice_import-fiscal_position
branch
from
e83c606 to
58f7e36
Compare
OCA-git-bot
added
series:18.0
mod:account_invoice_import
mt-software-de
force-pushed
the
18-fix-account_invoice_import-fiscal_position
branch
from
58f7e36 to
b2ab15f
Compare
arnaudlayec
approved these changes
May 12, 2026
Contributor
arnaudlayec
left a comment
arnaudlayec
left a comment
There was a problem hiding this comment.
All good for me, I think it is very helpful
Author
|
@alexis-via could you maybe give this PR a second review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right only the fiscal position is used if it is directly set on the partner.
In a normal odoo environment it isn't the case that the fiscal position needs to be set,
because it is selected automatically.
This change uses the method
_get_fiscal_positionwhich either returns the manually set fiscal position or the automatically detected on.