[18.0][FIX] hr_expense_advance_clearing: Check approval before other modules might intervene.#309
Merged
OCA-git-bot merged 1 commit intoJul 8, 2025
Conversation
…s might intervene. TT55529
Contributor
|
Hi @kittiu, |
pedrobaeza
approved these changes
Jul 7, 2025
Member
|
/ocabot merge patch |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at ad6bfb1. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While migrating hr_expense_invoice #308, it conflicted with this module, so i made a fix.
This is the error in ci: https://github.com/OCA/hr-expense/actions/runs/16047191168/job/45281217754#step:8:176
I don't have enough experience with this module to know if it will have undesired side effects, however in my tests, i haven't found any.
I also fixed translations for validation errors, as f strings are not properly translatable.
Can you please review?
@kittiu @Saran440
@Tecnativa TT55529