Skip to content

[18.0][MIG] hr_expense_widget_o2m#312

Closed
TheerayutEncoder wants to merge 10 commits into
OCA:18.0from
ecosoft-odoo:18.0-mig-hr_expense_widget_o2m
Closed

[18.0][MIG] hr_expense_widget_o2m#312
TheerayutEncoder wants to merge 10 commits into
OCA:18.0from
ecosoft-odoo:18.0-mig-hr_expense_widget_o2m

Conversation

@TheerayutEncoder
Copy link
Copy Markdown
Member

Standard Migration

Hi @kittiu, @Saran440
Relate to

on version 18.0 groups_id also removed from ir.ui.view
That means we cannot configure it to use O2M widget by groups; we can only enable this feature by installing or uninstalling it.

@TheerayutEncoder TheerayutEncoder changed the title 18.0 mig hr expense widget o2m [18.0][MIG] hr_expense_widget_o2m Aug 30, 2025
Copy link
Copy Markdown
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review 👍

@Saran440
Copy link
Copy Markdown
Member

/ocabot migration hr_expense_widget_o2m

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Sep 10, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 10, 2025
10 tasks
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 11, 2026
@Saran440 Saran440 removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 21, 2026
Copy link
Copy Markdown
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step to test:

  1. Create hr.expense.sheet and add a line
  2. Change quantity or Total > Save
  3. Click in each line > edit price > Save
  4. Click from smart button expense

Result:
The price still shows the old value.

I think this behavior may be related to the widget implementation in Odoo 18 and the way the x2many state is handled.

To simplify the user experience, I created an alternative module using the standard Odoo behavior with open_form_view:
#342

What do you think?

@TheerayutEncoder
Copy link
Copy Markdown
Member Author

Step to test:

  1. Create hr.expense.sheet and add a line
  2. Change quantity or Total > Save
  3. Click in each line > edit price > Save
  4. Click from smart button expense

Result: The price still shows the old value.

I think this behavior may be related to the widget implementation in Odoo 18 and the way the x2many state is handled.

To simplify the user experience, I created an alternative module using the standard Odoo behavior with open_form_view: #342

What do you think?

Yes, it's better to just use standard odoo like open_form_view.

@Saran440 Saran440 closed this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants