[18.0] [REF] hr_expense_advance_clearing: Check if all moves are posted (compatibility)#322
Merged
OCA-git-bot merged 1 commit intoJan 21, 2026
Conversation
Contributor
|
Hi @kittiu, |
…patibility) Since some other modules can introduce other moves to the expense sheet, this refactor allow some compatibility between those modules without changing behavior on this module.
Shide
force-pushed
the
18.0-many_account_move_ids-hr_expense_advance_clearing
branch
from
1eae84e to
2be9623
Compare
Contributor
|
This PR has the |
yajo
approved these changes
Jan 20, 2026
EmilioPascual
approved these changes
Jan 21, 2026
Member
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 8c68e67. Thanks a lot for contributing to OCA. ❤️ |
yajo
deleted the
18.0-many_account_move_ids-hr_expense_advance_clearing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since some other modules can introduce other moves to the expense sheet, this refactor allow some compatibility between those modules without changing behavior on this module.
This the module hr_expense_employee_payment allows to create more journal items in expense sheet, a mapped has been added to maintain consistance and don't break things.
MT-12694 @moduon @rafaelbn @yajo @kittiu please review if you want 😄