[19.0][WIP][ADD] hr_expense_trip: Link expenses with trips#337
Open
CRogos wants to merge 1 commit into
Open
Conversation
CRogos
force-pushed
the
copilot/add-hr-expense-trip-module-again
branch
from
27cce90 to
b64f08f
Compare
|
Here is my proposal Not sure if i like the idea to skip the reports. For trips I would propose to get back the sheets logic and extend it with a trip module (date field and checker) @smaddlsoft Trips was your initial requirement. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because hr.expense.sheet (Expense Reports) are discontinued in v19, this module adds a new possibility to link expenses to a trip.
@madmooose, @smaddlsoft your feedback is welcome