[19.0][MIG] mail_tracking: Migration to 19.0#140
Open
quoc-pn wants to merge 107 commits into
Open
Conversation
This was referenced Jan 24, 2026
quoc-pn
force-pushed
the
19.0-mig-mail_tracking
branch
3 times, most recently
from
e6b718c to
0edcf49
Compare
Member
Author
|
It seems the instance test can not send emails, so the actions test keeps failing |
quoc-pn
force-pushed
the
19.0-mig-mail_tracking
branch
from
0edcf49 to
506778b
Compare
|
Super! Any news when this will be merged? |
cuongnmtm
suggested changes
Feb 2, 2026
quoc-pn
force-pushed
the
19.0-mig-mail_tracking
branch
4 times, most recently
from
7767756 to
990383e
Compare
cuongnmtm
suggested changes
Feb 5, 2026
quoc-pn
force-pushed
the
19.0-mig-mail_tracking
branch
from
990383e to
6259569
Compare
|
Since I really need this module, one question: Do you guys expect major changes to come that will impact the database or can i already install this version and update to the official version later? |
|
@AquaMCU I do not see any major changes that would impact the database or require a data migration. My teammate will work on getting all PR checks to pass. |
quoc-pn
force-pushed
the
19.0-mig-mail_tracking
branch
from
6259569 to
468d3ca
Compare
|
Wow! It is nice to get involved ;) I tested on my installation ( 19.0 CE ) and it works perfect! |
1 task
quoc-pn
force-pushed
the
19.0-mig-mail_tracking
branch
6 times, most recently
from
a6ab858 to
45173ef
Compare
quoc-pn
force-pushed
the
19.0-mig-mail_tracking
branch
from
45173ef to
fb7bb95
Compare
Add autovacuum to mail_tracking_email that removes old records based on new configuration variable mail_tracking_email_max_age_days. Due to possibly a large number of records to be deleted on first run, set a default limit of 5000 per run.
…peruser The previous condition to apply access restriction to mail tracking email records was not applied to every user having access rights settings. Hence, this could lead up to AccessError when trying to open the model's action through the web client. Since the access to these records is based on the same restrictions that are implemented for mail.message model in the mail module, we ended up having access error as there were records we were allowed to search but not to read, due to the restriction being more permissive in the case of mail tracking email. But since the check_access method of this model is actually checking if the user has access to the related mail.message, we need to have the same conditions to avoid such access error for users with settings access that are not superuser.
This prop was removed during the migration to 18.0 (974b492), probably by mistake, and yet causing this regression. The `onUpdate` prop is used here: https://github.com/OCA/mail/blob/b0226505/mail_tracking/static/src/core/chatter/chatter.xml#L34 And so the UI breaks whene trying to render a thread that contains failed messages. Traceback: ``` UncaughtPromiseError > OwlError Uncaught Promise > Invalid props for component 'FailedMessage': unknown key 'onUpdate' Occured on localhost:8069 on 2025-09-04 17:57:30 GMT OwlError: Invalid props for component 'FailedMessage': unknown key 'onUpdate' Error: Invalid props for component 'FailedMessage': unknown key 'onUpdate' at Object.validateProps (http://localhost:8069/web/assets/debug/web.assets_web.js:11207:19) (/web/static/lib/owl/owl.js:3214) at Chatter.template (eval at compile (http://localhost:8069/web/assets/debug/web.assets_web.js:13754:20), <anonymous>:30:17) (/web/static/lib/owl/owl.js:5761) at Chatter.template (eval at compile (http://localhost:8069/web/assets/debug/web.assets_web.js:13754:20), <anonymous>:194:30) (/web/static/lib/owl/owl.js:5761) at Fiber._render (http://localhost:8069/web/assets/debug/web.assets_web.js:9776:38) (/web/static/lib/owl/owl.js:1783) at Fiber.render (http://localhost:8069/web/assets/debug/web.assets_web.js:9768:18) (/web/static/lib/owl/owl.js:1775) at ComponentNode.updateAndRender (http://localhost:8069/web/assets/debug/web.assets_web.js:10564:19) (/web/static/lib/owl/owl.js:2571) ```
This is dead code since the Migration to 18.0 (974b492), when the `messaging_service_patch.esm.js` was removed and replaced by a new `mail_core_common_service_patch.esm.js`
…thod The controller that called this method was removed during the Migration to 16.0, OCA/social@ef73e2d This method is a left-over, it's not used anywhere since.
There's already a collapsable panel for failed messages in the chatter. Having this other panel is totally redundant, and it was a bit glitchy too.
Before this commit, when the user clicked on the icon of a message, the following error occurred: ValueError: not enough values to unpack (expected 4, got 0) Complementary to 86e188c
…s reviewed Before these changes, when the bus event was received in tabs that did not have the message open, an error appeared because the system was not able to find the message. After these changes, if the message is not available on the screen, the process continues because synchronization will not be necessary, and therefore the error will no longer occur.
quoc-pn
force-pushed
the
19.0-mig-mail_tracking
branch
from
cf1aeb3 to
6d35c03
Compare
|
Can we merge this? |
Member
Author
@AquaMCU, please help review/test and approve the PR. I will work to resolve the failed checks. |
|
Tested and LGTM |
quoc-pn
force-pushed
the
19.0-mig-mail_tracking
branch
from
552355a to
733d11c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove wizard model
mail.resend.messageand related code odoo/odoo@7e30fa8