[FIX] Hide OCA banner image, if it's not an OCA repo.

[legalsylvain]

Rational: this tool can be used for repo out of OCA context. For the time being, a big OCA banner is displayed in all description of modules. This gives the impression that the module was developed by the OCA and complies with OCA standards. (quality, stability, etc.), which is not true.
This commit so removes the OCA banner in such situation. (similar as in the end of the template, with the sentence 'To learn how please visit https://odoo-community.org/page/Contribute.').

Ex : https://github.com/grap/grap-odoo-custom/tree/16.0/fermente_web_environment_ribbon

[legalsylvain]

Improvment of #642 and #656

@dora-jurcevic, @etobella, @rousseldenis, @sbidoul : could you take a look on this trivial one ?

Thanks !

[sbidoul]

Fine with me although <tongue-in-cheek> why making it easy to hide it</tongue-in-cheek> ?

[legalsylvain]

Fine with me although <tongue-in-cheek> why making it easy to hide it</tongue-in-cheek> ?

Not sure to understand the tongue in cheek !

As said, for the time being, the banner appears in all the grap modules that are basically :

• custom modules, that have nothing to see with OCA.
• incubator modules, that will be maybe in a day, under OCA umbrella.

For me :

• it is weird to display a huge OCA logo in module description that are not developed by OCA.
• Sometimes people use GRAP modules, and I don't want them to think there are OCA modules. (especially since we can choose to break the API in stable releases if necessary.)

Do you think it's relevant to display an OCA banner in non OCA repo ? Let me know !

[sbidoul]

Yeah my comment is not really serious and I understand the reason for the PR.

It's just that the banner does not say it's an OCA module, it's a call for funding and participation to the OCA, so there is an angle where you can see it as meaningful for non-OCA modules too.

But anyway, I'm fine with merging this.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[legalsylvain]

It's just that the banner does not say it's an OCA module

Indeed. but it's ambiguous. I received some question from people asking if a GRAP module was developped by / under OCA umbrella.

Anyway. Any maintainer could merge this approved PR ?

Thanks in advance ! 🙏