[18.0][ADD] mis_builder: add multi-company demo data#788
Open
dnplkndll wants to merge 1 commit into
Open
Conversation
Adds demo data that creates a second company with expense accounts, journal entries, and a multi-company MIS report instance. Useful for exercising multi-company report rendering in tests and demos. Only loaded when demo data is enabled. Includes a `_post_demo_moves()` helper on `mis.report.instance` that posts the seeded draft journal entries so the demo report renders non-zero values.
Contributor
|
Hi @sbidoul, |
Member
|
Thanks. I'll review this topic and work on the v19 migration by end of May, likely during the sprint in Spain . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds demo data exercising multi-company MIS reports:
mis.report.instanceconfigured withmulti_company=Trueandquery_company_idsset across both companies_post_demo_moves()helper onmis.report.instancethat posts the seeded draft journal entries so the demo report renders non-zero valuesOnly loaded when demo data is enabled (
--without-demo=False).Why split from #782?
Per @sbidoul's review on #782, splitting the demo data out so the runtime fix can move independently. The fix in #782 stands on its own; this PR adds the fixture that makes the multi-company rendering visible/testable from the demo install.
Test plan
-i mis_builder --without-demo=False#782applied: rendering should expose theaccount.company_idAttributeError this demo is designed to surfaceCompanion of: #782