Skip to content

[16.0][ADD] sale_purchase_inter_company - #456

Closed
chafique-delli wants to merge 1 commit into
OCA:16.0from
akretion:16.0-add-sale_purchase_inter_company
Closed

[16.0][ADD] sale_purchase_inter_company#456
chafique-delli wants to merge 1 commit into
OCA:16.0from
akretion:16.0-add-sale_purchase_inter_company

Conversation

@chafique-delli

@chafique-delli chafique-delli commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

@chafique-delli
chafique-delli force-pushed the 16.0-add-sale_purchase_inter_company branch 3 times, most recently from 48e0b48 to 66d9170 Compare March 17, 2023 14:23
@chafique-delli
chafique-delli force-pushed the 16.0-add-sale_purchase_inter_company branch from 66d9170 to 690adca Compare April 24, 2023 10:27
@chafique-delli

Copy link
Copy Markdown
Contributor Author

@sebastienbeau , @Kev-Roche , can you review, please ?

@hitrosol

Copy link
Copy Markdown

Does this module plan to be compatible with the stock type product as well ?

I tried this on runboat. I installed the Inventory to test as a stock type Product.
I have checked the Purchase from Sale, put Michell Admin as Intercompany Purchase User.
Create Sales Order, put the qty and specific unit price then confirm the Sales Order.
Result.

  • The Unit Price become 0. --> It supposed to be the unit price as set in the Quotation.
  • The Purchase Order in the Vendor Company created with correct qty and Unit Price is 0 as well. --> if the Unit price in Sales Order were correct, then the unit price in Purchase Order should show the same amount.

@chafique-delli

Copy link
Copy Markdown
Contributor Author

Does this module plan to be compatible with the stock type product as well ?

I tried this on runboat. I installed the Inventory to test as a stock type Product. I have checked the Purchase from Sale, put Michell Admin as Intercompany Purchase User. Create Sales Order, put the qty and specific unit price then confirm the Sales Order. Result.

  • The Unit Price become 0. --> It supposed to be the unit price as set in the Quotation.
  • The Purchase Order in the Vendor Company created with correct qty and Unit Price is 0 as well. --> if the Unit price in Sales Order were correct, then the unit price in Purchase Order should show the same amount.

This module is compatible with the service type product i.e. when you do not want to depend on the Inventory module.
For the stock type product, it is the sale_purchase_stock_inter_company module: #463

@jumeldi74

Copy link
Copy Markdown

Please add an unit test to run the uncovered function mentioned by codecov

@jumeldi74

Copy link
Copy Markdown

Please add an unit test to run the uncovered function mentioned by codecov

If you don't mind, I'll add it

@chafique-delli

Copy link
Copy Markdown
Contributor Author

If you don't mind, I'll add it

Yes, I do. Thank you for your time.

@chafique-delli
chafique-delli force-pushed the 16.0-add-sale_purchase_inter_company branch from 690adca to df2f5b0 Compare October 10, 2023 15:48
@chafique-delli

Copy link
Copy Markdown
Contributor Author

@legalsylvain

Copy link
Copy Markdown
Contributor

Any review @Kev-Roche, @sebastienbeau , @metaminux ?

@legalsylvain legalsylvain added this to the 16.0 milestone Dec 17, 2023
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 21, 2024
@github-actions github-actions Bot closed this May 26, 2024
@Kev-Roche

Kev-Roche commented Jun 26, 2024

Copy link
Copy Markdown
Contributor

Hello @chafique-delli , I made a fix here, what do you think ? akretion#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants