[IMP] oca_all: add base_deterministic_session_gc#64
Closed
HekkiMelody wants to merge 2 commits intoOCA:14.0from
Closed
[IMP] oca_all: add base_deterministic_session_gc#64HekkiMelody wants to merge 2 commits intoOCA:14.0from
HekkiMelody wants to merge 2 commits intoOCA:14.0from
Conversation
Collaborator
|
Hi @petrus-v, |
Contributor
Author
|
It looks like building the docker image fails because it cannot install postgres https://github.com/OCA/oca-custom/actions/runs/17727340361/job/50370780890?pr=64#step:5:330 I don't think focal is included among the official ubuntu repositories by postgres any longer. |
HekkiMelody
force-pushed
the
14.0-base-deterministic-session-gc
branch
from
be7be72 to
8ebbb7d
Compare
Contributor
Author
|
I've rebased on top of #63 which is not yet merged |
HekkiMelody
force-pushed
the
14.0-base-deterministic-session-gc
branch
2 times, most recently
from
4c5392d to
cd90018
Compare
3 tasks
Contributor
|
@aleuffre So I applied this on test.odoo-community.org, but when running the scheduled action, I run into: |
Contributor
|
Ah wait, I need to add the module in |
The module makes session garbage collection deterministic To use the module, it needs to be added to the server_wide_modules conf options Another option should also be added to set gc for all sessions older than 3 days ;3 days = 60*60*24*3 seconds session_expiry_delay = 259200
HekkiMelody
force-pushed
the
14.0-base-deterministic-session-gc
branch
from
cd90018 to
fd1b4bb
Compare
Contributor
|
Could you close this PR your work has been integrated in #65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module makes session garbage collection deterministic To use the module, it needs to be added to the
server_wide_modules conf options
Another option should also be added
to set gc for all sessions older than 3 days
(it's not quite possible to test this in runboat unfortunately)
Closes task 909851
Depends #63