Skip to content

[18.0][FIX] pos_product_multi_barcode: add fallback search for barcode_ids in POS barcode resolution#1533

Open
ppyczko wants to merge 1 commit into
OCA:18.0from
APSL:18.0-fix-non-indexed-barcodes-ids-search-pos_product_multi_barcode
Open

[18.0][FIX] pos_product_multi_barcode: add fallback search for barcode_ids in POS barcode resolution#1533
ppyczko wants to merge 1 commit into
OCA:18.0from
APSL:18.0-fix-non-indexed-barcodes-ids-search-pos_product_multi_barcode

Conversation

@ppyczko
Copy link
Copy Markdown

@ppyczko ppyczko commented Apr 23, 2026

POS barcode lookup only worked for products loaded in the POS indexed dataset (limited by point_of_sale.limited_product_count), causing some valid barcodes from barcode_ids to be ignored during scanning.

This fix adds a backend fallback search on product.barcode_ids when the barcode is not found in the indexed data.

cc https://github.com/APSL 43026

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador @cubells @isugac @palomagrc93 @LlucSG @shirashi3771 please review

@OCA-git-bot OCA-git-bot added series:18.0 mod:pos_product_multi_barcode Module pos_product_multi_barcode labels Apr 23, 2026
@ppyczko ppyczko changed the title [FIX] pos_product_multi_barcode: add fallback search for barcode_ids in POS barcode resolution [18.0][FIX] pos_product_multi_barcode: add fallback search for barcode_ids in POS barcode resolution Apr 23, 2026
@ppyczko ppyczko force-pushed the 18.0-fix-non-indexed-barcodes-ids-search-pos_product_multi_barcode branch from b51a523 to 5294e9c Compare April 23, 2026 13:56
@ppyczko ppyczko marked this pull request as ready for review April 23, 2026 14:06
Copy link
Copy Markdown
Contributor

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review

shirashi3771

This comment was marked as duplicate.

Copy link
Copy Markdown

@shirashi3771 shirashi3771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , code review and functional review.

Copy link
Copy Markdown

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants